Merge pull request #122 from greut/magick

Save as bimg.MAGICK

vips.go

@@ -380,6 +380,8 @@ func vipsSave(image *C.VipsImage, o vipsSaveOptions) ([]byte, error) {
 		return nil, errors.New("VIPS cannot save to PDF")
 	case SVG:
 		return nil, errors.New("VIPS cannot save to SVG")
+	case MAGICK:
+		return nil, errors.New("VIPS cannot save to MAGICK")
 	default:
 		saveErr = C.vips_jpegsave_bridge(tmpImage, &ptr, &length, 1, quality, interlace)
 		break

vips_test.go

@@ -29,15 +29,36 @@ func TestVipsRead(t *testing.T) {
 }
 
 func TestVipsSave(t *testing.T) {
-	image, _, _ := vipsRead(readImage("test.jpg"))
+	types := [...]ImageType{JPEG, PNG, TIFF, WEBP}
-	options := vipsSaveOptions{Quality: 95, Type: JPEG, Interlace: true}
 
-	buf, err := vipsSave(image, options)
+	for _, typ := range types {
-	if err != nil {
+		image, _, _ := vipsRead(readImage("test.jpg"))
-		t.Fatal("Cannot save the image")
+		options := vipsSaveOptions{Quality: 95, Type: typ}
+
+		buf, err := vipsSave(image, options)
+		if err != nil {
+			t.Fatalf("Cannot save the image as '%v'", ImageTypes[typ])
+		}
+		if len(buf) == 0 {
+			t.Fatalf("Empty saved '%v' image", ImageTypes[typ])
+		}
 	}
-	if len(buf) == 0 {
+}
-		t.Fatal("Empty image")
+
+func TestVipsCannotSave(t *testing.T) {
+	types := [...]ImageType{GIF, PDF, SVG, MAGICK}
+
+	for _, typ := range types {
+		image, _, _ := vipsRead(readImage("test.jpg"))
+		options := vipsSaveOptions{Quality: 95, Type: typ}
+
+		buf, err := vipsSave(image, options)
+		if err == nil {
+			t.Fatalf("Format '%v' shouldn't be supported", ImageTypes[typ])
+		}
+		if len(buf) != 0 {
+			t.Fatalf("'%v' image is not empty", ImageTypes[typ])
+		}
 	}
 }