Optimize School lookup by qualtrics code query

pull/1/head
Alex Basson 4 years ago
parent c66134e25e
commit fd55c7c82a

@ -15,7 +15,8 @@ class School < ApplicationRecord
def self.find_by_district_code_and_school_code(district_code, school_code) def self.find_by_district_code_and_school_code(district_code, school_code)
School School
.where(district: District.find_by_qualtrics_code(district_code)) .joins(:district)
.where(districts: {qualtrics_code: district_code})
.find_by_qualtrics_code(school_code) .find_by_qualtrics_code(school_code)
end end

@ -36,7 +36,7 @@ class SurveyResponsesDataLoader
return if school.nil? return if school.nil?
survey_items.each do |survey_item| survey_items.each do |survey_item|
return unless SurveyItemResponse.where(response_id: response_id, survey_item: survey_item).empty? return unless SurveyItemResponse.find_by(response_id: response_id, survey_item: survey_item).nil?
likert_score = row[survey_item.survey_item_id] likert_score = row[survey_item.survey_item_id]
next if likert_score.nil? next if likert_score.nil?

Loading…
Cancel
Save