Address bug related to story #182855028

app/models/measure.rb

@@ -183,18 +183,17 @@ class Measure < ActiveRecord::Base
   end
 
   def sufficient_student_data?(school:, academic_year:)
-    false unless includes_student_survey_items?
+    return false unless includes_student_survey_items?
-    false if no_student_responses_exist?(school:, academic_year:)
+    return false if no_student_responses_exist?(school:, academic_year:)
 
-    # this gets memoized on first run so check to make sure
     subcategory.response_rate(school:, academic_year:).meets_student_threshold?
   end
 
   def sufficient_teacher_data?(school:, academic_year:)
-    return @sufficient_teacher_data ||= false unless includes_teacher_survey_items?
+    return false unless includes_teacher_survey_items?
-    return @sufficient_teacher_data ||= false if no_teacher_responses_exist?(school:, academic_year:)
+    return false if no_teacher_responses_exist?(school:, academic_year:)
 
-    @sufficient_teacher_data ||= subcategory.response_rate(school:, academic_year:).meets_teacher_threshold?
+    subcategory.response_rate(school:, academic_year:).meets_teacher_threshold?
   end
 
   def no_student_responses_exist?(school:, academic_year:)

lib/tasks/data.rake

@@ -67,11 +67,10 @@ namespace :data do
   end
   desc 'load students'
   task load_students: :environment do
-    files = [ '2021-22_winchester_student_survey_responses.csv' ]
+    files = ['2021-22_attleboro_student_survey_responses.csv',
-    # files = ['2021-22_attleboro_student_survey_responses.csv',
+            '2021-22_lowell_milford_student_survey_responses.csv',
-    #         '2021-22_lowell_milford_student_survey_responses.csv',
+            '2021-22_revere_somerville_wareham_student_survey_responses.csv',
-    #         '2021-22_revere_somerville_wareham_student_survey_responses.csv',
+            '2021-22_winchester_student_survey_responses.csv' ]
-    #         '2021-22_winchester_student_survey_responses.csv' ]
     files.each do |file|
       file = Rails.root.join('data', 'survey_responses', file)
       puts "=====================> Loading student data from csv at path: #{file}"