@ -1,6 +1,6 @@
require " rails_helper " require " rails_helper "
describe do describe Overview:: VarianceChartRowPresenter do
let ( :watch_low_benchmark ) { 2 . 9 }
let ( :watch_low_benchmark ) { 2 . 9 }
let ( :growth_low_benchmark ) { 3 . 1 }
let ( :growth_low_benchmark ) { 3 . 1 }
let ( :approval_low_benchmark ) { 3 . 6 }
let ( :approval_low_benchmark ) { 3 . 6 }
@ -30,7 +30,7 @@ describe VarianceChartRowPresenter do
end
end
let ( :presenter ) do
let ( :presenter ) do
. new measure : , score :
Overview:: VarianceChartRowPresenter. new measure : , score :
end
end
shared_examples_for " measure_name " do
shared_examples_for " measure_name " do
@ -138,9 +138,19 @@ describe VarianceChartRowPresenter do
context " when a measure does not contain admin data items " do
context " when a measure does not contain admin data items " do
let ( :score ) { Score . new ( average : nil , meets_teacher_threshold : false , meets_student_threshold : false ) }
let ( :score ) { Score . new ( average : nil , meets_teacher_threshold : false , meets_student_threshold : false ) }
<< << << < HEAD
it " it does not show a partial data indicator " do
it " it does not show a partial data indicator " do
presenter_without_admin_data = VarianceChartRowPresenter . new measure : measure_without_admin_data_items ,
presenter_without_admin_data = VarianceChartRowPresenter . new measure : measure_without_admin_data_items ,
score : score
score : score
|| || || | parent of a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
it 'it does not show a partial data indicator' do
presenter_without_admin_data = VarianceChartRowPresenter . new measure : measure_without_admin_data_items ,
score : score
=== === =
it " it does not show a partial data indicator " do
presenter_without_admin_data = Overview :: VarianceChartRowPresenter . new ( measure : measure_without_admin_data_items ,
score : )
>> >> >> > a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
expect ( presenter_without_admin_data . show_partial_data_indicator? ) . to be false
expect ( presenter_without_admin_data . show_partial_data_indicator? ) . to be false
end
end
end
end
@ -157,6 +167,7 @@ describe VarianceChartRowPresenter do
name : " Some Title "
name : " Some Title "
)
)
scale_with_admin_data = create ( :scale , measure : measure_with_admin_data )
scale_with_admin_data = create ( :scale , measure : measure_with_admin_data )
<< << << < HEAD
create :admin_data_item ,
create :admin_data_item ,
scale : scale_with_admin_data ,
scale : scale_with_admin_data ,
watch_low_benchmark : watch_low_benchmark ,
watch_low_benchmark : watch_low_benchmark ,
@ -167,8 +178,37 @@ describe VarianceChartRowPresenter do
score : Score . new (
score : Score . new (
average : 3 . 7 , meets_teacher_threshold : true , meets_student_threshold : true
average : 3 . 7 , meets_teacher_threshold : true , meets_student_threshold : true
)
)
|| || || | parent of a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
create :admin_data_item ,
scale : scale_with_admin_data ,
watch_low_benchmark : watch_low_benchmark ,
growth_low_benchmark : growth_low_benchmark ,
approval_low_benchmark : approval_low_benchmark ,
ideal_low_benchmark : ideal_low_benchmark
admin_data_presenter = VarianceChartRowPresenter . new measure : measure_with_admin_data ,
score : Score . new (
average : 3 . 7 , meets_teacher_threshold : true , meets_student_threshold : true
)
=== === =
create ( :admin_data_item ,
scale : scale_with_admin_data ,
watch_low_benchmark : ,
growth_low_benchmark : ,
approval_low_benchmark : ,
ideal_low_benchmark : )
admin_data_presenter = Overview :: VarianceChartRowPresenter . new measure : measure_with_admin_data ,
score : Score . new (
average : 3 . 7 , meets_teacher_threshold : true , meets_student_threshold : true
)
>> >> >> > a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
expect ( admin_data_presenter . show_partial_data_indicator? ) . to be true
expect ( admin_data_presenter . show_partial_data_indicator? ) . to be true
<< << << < HEAD
expect ( admin_data_presenter . partial_data_sources ) . to eq [ " school data " ]
expect ( admin_data_presenter . partial_data_sources ) . to eq [ " school data " ]
|| || || | parent of a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
expect ( admin_data_presenter . partial_data_sources ) . to eq [ 'administrative data' ]
=== === =
expect ( admin_data_presenter . partial_data_sources ) . to eq [ " administrative data " ]
>> >> >> > a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
end
end
end
end
@ -186,9 +226,19 @@ describe VarianceChartRowPresenter do
end
end
end
end
<< << << < HEAD
context " when there are sufficient teacher survey item responses " do
context " when there are sufficient teacher survey item responses " do
let ( :score ) { Score . new ( average : nil , meets_teacher_threshold : true , meets_student_threshold : true ) }
let ( :score ) { Score . new ( average : nil , meets_teacher_threshold : true , meets_student_threshold : true ) }
it " does not show a partial data indicator " do
it " does not show a partial data indicator " do
|| || || | parent of a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
context 'when there are sufficient teacher survey item responses' do
let ( :score ) { Score . new ( average : nil , meets_teacher_threshold : true , meets_student_threshold : true ) }
it 'does not show a partial data indicator' do
=== === =
context " when there are sufficient teacher survey item responses " do
let ( :score ) { Score . new ( average : nil , meets_teacher_threshold : true , meets_student_threshold : true ) }
it " does not show a partial data indicator " do
>> >> >> > a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
expect ( presenter . show_partial_data_indicator? ) . to be false
expect ( presenter . show_partial_data_indicator? ) . to be false
end
end
end
end
@ -213,8 +263,16 @@ describe VarianceChartRowPresenter do
create :admin_data_item , scale :
create :admin_data_item , scale :
end
end
<< << << < HEAD
it " returns the sources for partial results of administrative data and student survey results " do
it " returns the sources for partial results of administrative data and student survey results " do
expect ( presenter . partial_data_sources ) . to eq [ " student survey results " , " school data " ]
expect ( presenter . partial_data_sources ) . to eq [ " student survey results " , " school data " ]
|| || || | parent of a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
it 'returns the sources for partial results of administrative data and student survey results' do
expect ( presenter . partial_data_sources ) . to eq [ 'student survey results' , 'administrative data' ]
=== === =
it " returns the sources for partial results of administrative data and student survey results " do
expect ( presenter . partial_data_sources ) . to eq [ " student survey results " , " administrative data " ]
>> >> >> > a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
end
end
end
end
end
end
@ -231,6 +289,7 @@ describe VarianceChartRowPresenter do
it " selects a longer bar before a shorter bar for measures in the approval/ideal zones " do
it " selects a longer bar before a shorter bar for measures in the approval/ideal zones " do
scale_with_student_survey_items = create ( :scale , measure : )
scale_with_student_survey_items = create ( :scale , measure : )
create ( :student_survey_item ,
create ( :student_survey_item ,
<< << << < HEAD
scale : scale_with_student_survey_items ,
scale : scale_with_student_survey_items ,
watch_low_benchmark : ,
watch_low_benchmark : ,
growth_low_benchmark : ,
growth_low_benchmark : ,
@ -238,13 +297,52 @@ describe VarianceChartRowPresenter do
ideal_low_benchmark : )
ideal_low_benchmark : )
approval_presenter = VarianceChartRowPresenter . new measure : measure , score : Score . new ( average : 3 . 7 , meets_teacher_threshold : true , meets_student_threshold : true )
approval_presenter = VarianceChartRowPresenter . new measure : measure , score : Score . new ( average : 3 . 7 , meets_teacher_threshold : true , meets_student_threshold : true )
ideal_presenter = VarianceChartRowPresenter . new measure : measure , score : Score . new ( average : 4 . 4 , meets_teacher_threshold : true , meets_student_threshold : true )
ideal_presenter = VarianceChartRowPresenter . new measure : measure , score : Score . new ( average : 4 . 4 , meets_teacher_threshold : true , meets_student_threshold : true )
|| || || | parent of a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
scale : scale_with_student_survey_items ,
watch_low_benchmark : ,
growth_low_benchmark : ,
approval_low_benchmark : ,
ideal_low_benchmark : )
approval_presenter = VarianceChartRowPresenter . new measure : measure , score : Score . new ( average : 3 . 7 , meets_teacher_threshold : true , meets_student_threshold : true )
ideal_presenter = VarianceChartRowPresenter . new measure : measure , score : Score . new ( average : 4 . 4 , meets_teacher_threshold : true , meets_student_threshold : true )
=== === =
scale : scale_with_student_survey_items ,
watch_low_benchmark : ,
growth_low_benchmark : ,
approval_low_benchmark : ,
ideal_low_benchmark : )
approval_presenter = Overview :: VarianceChartRowPresenter . new measure : ,
score : Score . new (
average : 3 . 7 , meets_teacher_threshold : true , meets_student_threshold : true
)
ideal_presenter = Overview :: VarianceChartRowPresenter . new measure : ,
score : Score . new (
average : 4 . 4 , meets_teacher_threshold : true , meets_student_threshold : true
)
>> >> >> > a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
expect ( ideal_presenter < = > approval_presenter ) . to be < 0
expect ( ideal_presenter < = > approval_presenter ) . to be < 0
expect ( [ approval_presenter , ideal_presenter ] . sort ) . to eq [ ideal_presenter , approval_presenter ]
expect ( [ approval_presenter , ideal_presenter ] . sort ) . to eq [ ideal_presenter , approval_presenter ]
end
end
<< << << < HEAD
it " selects a warning bar below a ideal bar " do
it " selects a warning bar below a ideal bar " do
warning_presenter = VarianceChartRowPresenter . new measure : measure , score : Score . new ( average : 1 . 0 , meets_teacher_threshold : true , meets_student_threshold : true )
warning_presenter = VarianceChartRowPresenter . new measure : measure , score : Score . new ( average : 1 . 0 , meets_teacher_threshold : true , meets_student_threshold : true )
ideal_presenter = VarianceChartRowPresenter . new measure : measure , score : Score . new ( average : 5 . 0 , meets_teacher_threshold : true , meets_student_threshold : true )
ideal_presenter = VarianceChartRowPresenter . new measure : measure , score : Score . new ( average : 5 . 0 , meets_teacher_threshold : true , meets_student_threshold : true )
|| || || | parent of a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
it 'selects a warning bar below a ideal bar' do
warning_presenter = VarianceChartRowPresenter . new measure : measure , score : Score . new ( average : 1 . 0 , meets_teacher_threshold : true , meets_student_threshold : true )
ideal_presenter = VarianceChartRowPresenter . new measure : measure , score : Score . new ( average : 5 . 0 , meets_teacher_threshold : true , meets_student_threshold : true )
=== === =
it " selects a warning bar below a ideal bar " do
warning_presenter = Overview :: VarianceChartRowPresenter . new measure : ,
score : Score . new (
average : 1 . 0 , meets_teacher_threshold : true , meets_student_threshold : true
)
ideal_presenter = Overview :: VarianceChartRowPresenter . new measure : ,
score : Score . new (
average : 5 . 0 , meets_teacher_threshold : true , meets_student_threshold : true
)
>> >> >> > a391acc ( feat : Add parent button to overview page and alter 'School Quality Framework Indicators' section to show parent scales )
expect ( warning_presenter < = > ideal_presenter ) . to be > 0
expect ( warning_presenter < = > ideal_presenter ) . to be > 0
expect ( [ warning_presenter , ideal_presenter ] . sort ) . to eq [ ideal_presenter , warning_presenter ]
expect ( [ warning_presenter , ideal_presenter ] . sort ) . to eq [ ideal_presenter , warning_presenter ]
end
end
Nelson Jovel
1 year ago