Revert "fix: Fixes #187294757. Data is hidden when selecting multiple years if the default year has no student data to show"

This reverts commit b9bdd707b5.

app/presenters/analyze/graph/column/ell_column/ell_count.rb

@@ -8,7 +8,7 @@ module Analyze
           end
 
           def n_size(year_index)
-            SurveyItemResponse.where(ell:, survey_item: measure.student_survey_items, school:, grade: grades,
+            SurveyItemResponse.where(ell:, survey_item: measure.student_survey_items, school:, grade: grades(year_index),
                                      academic_year: academic_years[year_index]).select(:response_id).distinct.count
           end
         end

app/presenters/analyze/graph/column/gender_column/gender_count.rb

@@ -8,7 +8,7 @@ module Analyze
           end
 
           def n_size(year_index)
-            SurveyItemResponse.where(gender:, survey_item: measure.student_survey_items, school:, grade: grades,
+            SurveyItemResponse.where(gender:, survey_item: measure.student_survey_items, school:, grade: grades(year_index),
                                      academic_year: academic_years[year_index]).select(:response_id).distinct.count
           end
         end

app/presenters/analyze/graph/column/grouped_bar_column_presenter.rb

@@ -114,7 +114,7 @@ module Analyze
         end
 
         def n_size(year_index)
-          SurveyItemResponse.where(survey_item: measure.student_survey_items, school:, grade: grades,
+          SurveyItemResponse.where(survey_item: measure.student_survey_items, school:, grade: grades(year_index),
                                    academic_year: academic_years[year_index]).select(:response_id).distinct.count
         end
 
@@ -137,8 +137,8 @@ module Analyze
           end
         end
 
-        def grades
+        def grades(year_index)
-          Respondent.by_school_and_year(school:, academic_year: academic_years)&.enrollment_by_grade&.keys
+          Respondent.by_school_and_year(school:, academic_year: academic_years[year_index]).enrollment_by_grade.keys
         end
 
         private

app/presenters/analyze/graph/column/income_column/income_count.rb

@@ -8,7 +8,7 @@ module Analyze
           end
 
           def n_size(year_index)
-            SurveyItemResponse.where(income:, survey_item: measure.student_survey_items, school:, grade: grades,
+            SurveyItemResponse.where(income:, survey_item: measure.student_survey_items, school:, grade: grades(year_index),
                                      academic_year: academic_years[year_index]).select(:response_id).distinct.count
           end
         end

app/presenters/analyze/graph/column/sped_column/sped_count.rb

@@ -8,7 +8,7 @@ module Analyze
           end
 
           def n_size(year_index)
-            SurveyItemResponse.where(sped:, survey_item: measure.student_survey_items, school:, grade: grades,
+            SurveyItemResponse.where(sped:, survey_item: measure.student_survey_items, school:, grade: grades(year_index),
                                      academic_year: academic_years[year_index]).select(:response_id).distinct.count
           end
         end