chore: prevent multiple lookups for the boston district by inlining the

sql
rpp-main
Nelson Jovel 2 years ago
parent b29e6a75ec
commit 7ba124ac91

@ -15,10 +15,6 @@ class District < ApplicationRecord
self.slug ||= name.parameterize self.slug ||= name.parameterize
end end
def self.boston
District.find_by_name("Boston")
end
def short_name def short_name
name.split(" ").first.downcase name.split(" ").first.downcase
end end

@ -16,7 +16,7 @@ class SurveyItemResponse < ActiveRecord::Base
has_one :measure, through: :survey_item has_one :measure, through: :survey_item
scope :exclude_boston, lambda { scope :exclude_boston, lambda {
where.not(school: District.boston.schools) if District.boston.present? includes(school: :district).where.not("district.name": "Boston")
} }
scope :averages_for_grade, lambda { |survey_items, school, academic_year, grade| scope :averages_for_grade, lambda { |survey_items, school, academic_year, grade|

Loading…
Cancel
Save