chore: remove student loader since loading students is now done with the survey response loaderpull/2/head
rebuilt
2 years ago
parent
2d90516f9f
commit
1a707eb6bc
@ -1,64 +0,0 @@
|
||||
# frozen_string_literal: true
|
||||
|
||||
class StudentLoader
|
||||
def self.load_data(filepath:, rules: [])
|
||||
File.open(filepath) do |file|
|
||||
headers = file.first
|
||||
headers_array = headers.split(",")
|
||||
|
||||
file.lazy.each_slice(1_000) do |lines|
|
||||
CSV.parse(lines.join, headers:).map do |row|
|
||||
row = SurveyItemValues.new(row:, headers: headers_array, genders: nil, survey_items: nil, schools:)
|
||||
next if rules.any? do |rule|
|
||||
rule.new(row:).skip_row?
|
||||
end
|
||||
|
||||
process_row(row:)
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
def self.from_file(file:, rules: [])
|
||||
headers = file.gets
|
||||
headers_array = headers.split(",")
|
||||
|
||||
until file.eof?
|
||||
line = file.gets
|
||||
next unless line.present?
|
||||
|
||||
CSV.parse(line, headers:).map do |row|
|
||||
row = SurveyItemValues.new(row:, headers: headers_array, genders: nil, survey_items: nil, schools:)
|
||||
next if rules.any? do |rule|
|
||||
rule.new(row:).skip_row?
|
||||
end
|
||||
|
||||
process_row(row:)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
def self.process_row(row:)
|
||||
student = Student.find_or_create_by(response_id: row.response_id, lasid: row.lasid)
|
||||
student.races.delete_all
|
||||
races = row.races
|
||||
races.map do |race|
|
||||
student.races << race
|
||||
end
|
||||
assign_student_to_responses(student:, response_id: row.response_id)
|
||||
end
|
||||
|
||||
def self.schools
|
||||
@schools ||= School.all.map { |school| [school.dese_id, school] }.to_h
|
||||
end
|
||||
|
||||
def self.assign_student_to_responses(student:, response_id:)
|
||||
responses = SurveyItemResponse.where(response_id:)
|
||||
loadable_responses = responses.map do |response|
|
||||
response.student = student
|
||||
response
|
||||
end
|
||||
|
||||
SurveyItemResponse.import(loadable_responses.flatten.compact, batch_size: 1_000, on_duplicate_key_update: :all)
|
||||
end
|
||||
end
|
||||
@ -1,160 +0,0 @@
|
||||
require "rails_helper"
|
||||
|
||||
describe StudentLoader do
|
||||
let(:path_to_student_responses) { Rails.root.join("spec", "fixtures", "test_2020-21_student_survey_responses.csv") }
|
||||
let(:american_indian) { create(:race, qualtrics_code: 1) }
|
||||
let(:asian) { create(:race, qualtrics_code: 2) }
|
||||
let(:black) { create(:race, qualtrics_code: 3) }
|
||||
let(:latinx) { create(:race, qualtrics_code: 4) }
|
||||
let(:white) { create(:race, qualtrics_code: 5) }
|
||||
let(:middle_eastern) { create(:race, qualtrics_code: 8) }
|
||||
let(:unknown_race) { create(:race, qualtrics_code: 99) }
|
||||
let(:multiracial) { create(:race, qualtrics_code: 100) }
|
||||
let(:female) { create(:gender, qualtrics_code: 1) }
|
||||
let(:male) { create(:gender, qualtrics_code: 2) }
|
||||
let(:another_gender) { create(:gender, qualtrics_code: 3) }
|
||||
let(:non_binary) { create(:gender, qualtrics_code: 4) }
|
||||
let(:unknown_gender) { create(:gender, qualtrics_code: 99) }
|
||||
|
||||
before :each do
|
||||
american_indian
|
||||
asian
|
||||
black
|
||||
latinx
|
||||
white
|
||||
middle_eastern
|
||||
unknown_race
|
||||
multiracial
|
||||
female
|
||||
male
|
||||
another_gender
|
||||
non_binary
|
||||
unknown_gender
|
||||
end
|
||||
|
||||
after :each do
|
||||
DatabaseCleaner.clean
|
||||
end
|
||||
xdescribe "#process_races" do
|
||||
context "as a standalone function" do
|
||||
it "race codes of 6 or 7 get classified as an unknown race" do
|
||||
codes = ["NA"]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [unknown_race]
|
||||
codes = []
|
||||
expect(StudentLoader.process_races(codes:)).to eq [unknown_race]
|
||||
codes = [1]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [american_indian]
|
||||
codes = [2]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [asian]
|
||||
codes = [3]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [black]
|
||||
codes = [4]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [latinx]
|
||||
codes = [5]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [white]
|
||||
codes = [8]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [middle_eastern]
|
||||
codes = [6]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [unknown_race]
|
||||
codes = [7]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [unknown_race]
|
||||
codes = [6, 7]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [unknown_race]
|
||||
codes = [1, 6, 7]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [american_indian]
|
||||
codes = [1, 6, 7, 2]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [american_indian, asian, multiracial]
|
||||
codes = [3, 6, 7, 6, 6, 7, 7, 6, 2]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [black, asian, multiracial]
|
||||
codes = [8, 2]
|
||||
expect(StudentLoader.process_races(codes:)).to eq [middle_eastern, asian, multiracial]
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
xdescribe "#add_multiracial_designation" do
|
||||
it "adds the multiracial race code to the list of races" do
|
||||
races = [unknown_race]
|
||||
expect(StudentLoader.add_multiracial_designation(races:)).to eq [unknown_race]
|
||||
races = [american_indian, asian]
|
||||
expect(StudentLoader.add_multiracial_designation(races:)).to eq [american_indian, asian, multiracial]
|
||||
races = [white]
|
||||
expect(StudentLoader.add_multiracial_designation(races:)).to eq [white]
|
||||
end
|
||||
end
|
||||
|
||||
# This fails in CI because github does not know what the key derivation salt is.
|
||||
# I'm not sure how to securely set the key derivation salt as an environment variable in CI
|
||||
describe "self.load_data" do
|
||||
context "load student data for all schools" do
|
||||
before :each do
|
||||
SurveyResponsesDataLoader.new.load_data filepath: path_to_student_responses
|
||||
StudentLoader.load_data filepath: path_to_student_responses
|
||||
end
|
||||
|
||||
it "ensures student responses load correctly" do
|
||||
assigns_student_to_the_survey_item_responses
|
||||
assigns_races_to_students
|
||||
is_idempotent_for_students
|
||||
end
|
||||
end
|
||||
|
||||
# TODO: get this test to run correctly. Since we are no longer seeding, we need to define schools, and districts; some Lowell, some not
|
||||
xcontext "When using the rule to skip non Lowell schools" do
|
||||
before :each do
|
||||
SurveyResponsesDataLoader.new.load_data filepath: path_to_student_responses
|
||||
StudentLoader.load_data filepath: path_to_student_responses, rules: [Rule::SkipNonLowellSchools]
|
||||
end
|
||||
|
||||
it "only loads student data for lowell" do
|
||||
expect(Student.find_by_response_id("student_survey_response_1")).to eq nil
|
||||
expect(Student.find_by_response_id("student_survey_response_3").races).to eq [unknown_race]
|
||||
expect(Student.find_by_response_id("student_survey_response_4").races).to eq [unknown_race]
|
||||
expect(Student.find_by_response_id("student_survey_response_5").races).to eq [american_indian, asian, black, latinx, white,
|
||||
middle_eastern, multiracial]
|
||||
expect(Student.find_by_response_id("student_survey_response_6").races).to eq [american_indian, asian, black, latinx, white,
|
||||
middle_eastern, multiracial]
|
||||
expect(Student.find_by_response_id("student_survey_response_7").races).to eq [unknown_race]
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
def assigns_student_to_the_survey_item_responses
|
||||
# The csv file has no responses for `student_survey_response_2` so we can't assign a student to nil responses
|
||||
expect(SurveyItemResponse.find_by_response_id("student_survey_response_2")).to eq nil
|
||||
|
||||
response_ids = %w[student_survey_response_1 student_survey_response_3
|
||||
student_survey_response_4
|
||||
student_survey_response_5
|
||||
student_survey_response_6
|
||||
student_survey_response_7]
|
||||
|
||||
response_ids.each do |response_id|
|
||||
responses = SurveyItemResponse.where(response_id:)
|
||||
responses.each do |response|
|
||||
expect(response.student).not_to eq nil
|
||||
expect(response.student).to eq Student.find_by_response_id(response_id)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
def assigns_races_to_students
|
||||
expect(Student.find_by_response_id("student_survey_response_1").races).to eq [american_indian]
|
||||
expect(Student.find_by_response_id("student_survey_response_2").races).to eq [asian, black, latinx, multiracial]
|
||||
expect(Student.find_by_response_id("student_survey_response_3").races).to eq [unknown_race]
|
||||
expect(Student.find_by_response_id("student_survey_response_4").races).to eq [unknown_race]
|
||||
expect(Student.find_by_response_id("student_survey_response_5").races).to eq [american_indian, asian, black, latinx, white,
|
||||
middle_eastern, multiracial]
|
||||
expect(Student.find_by_response_id("student_survey_response_6").races).to eq [american_indian, asian, black, latinx, white,
|
||||
middle_eastern, multiracial]
|
||||
expect(Student.find_by_response_id("student_survey_response_7").races).to eq [unknown_race]
|
||||
end
|
||||
|
||||
def is_idempotent_for_students
|
||||
number_of_students = Student.count
|
||||
number_of_responses = SurveyItemResponse.count
|
||||
StudentLoader.load_data filepath: path_to_student_responses
|
||||
expect(Student.count).to eq number_of_students
|
||||
expect(SurveyItemResponse.count).to eq number_of_responses
|
||||
end
|
||||
Loading…
Reference in new issue