perf: include survey items with measures to avoid n+1 queries when scoring by student/teacher survey items

rpp-main
rebuilt 3 years ago
parent 330b1c74b1
commit 05f535ed5c

@ -8,9 +8,9 @@ class OverviewController < SqmApplicationController
@variance_chart_row_presenters = measures.map(&method(:presenter_for_measure)) @variance_chart_row_presenters = measures.map(&method(:presenter_for_measure))
@category_presenters = Category.sorted.map { |category| CategoryPresenter.new(category:) } @category_presenters = Category.sorted.map { |category| CategoryPresenter.new(category:) }
@student_response_rate_presenter = ResponseRatePresenter.new(focus: :student, school: @school, @student_response_rate_presenter = ResponseRatePresenter.new(focus: :student, school: @school,
academic_year: @academic_year) academic_year: @academic_year)
@teacher_response_rate_presenter = ResponseRatePresenter.new(focus: :teacher, school: @school, @teacher_response_rate_presenter = ResponseRatePresenter.new(focus: :teacher, school: @school,
academic_year: @academic_year) academic_year: @academic_year)
end end
private private
@ -29,7 +29,7 @@ class OverviewController < SqmApplicationController
end end
def measures def measures
@measures ||= Measure.all.includes(%i[scales admin_data_items category subcategory]) @measures ||= Measure.all.includes(%i[scales admin_data_items category subcategory survey_items])
end end
def subcategories def subcategories

Loading…
Cancel
Save