gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-07 21:48:16 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor teacher response rate calculator

Browse source
This commit is contained in:
rebuilt 2022-06-22 08:49:16 -07:00
parent d0dcac701e
commit fa35a4230c
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/models/teacher_response_rate_calculator.rb
View file

@ -4,7 +4,7 @@ class TeacherResponseRateCalculator
def survey_item_count
@survey_item_count ||= @subcategory.measures.map do |measure|
measure.teacher_survey_items.reject do |survey_item|
survey_item.survey_item_responses.where(school: @school, academic_year: @academic_year).none?
survey_item.survey_item_responses.where(school:, academic_year:).none?
end.count
end.sum
end
@ -12,15 +12,15 @@ class TeacherResponseRateCalculator
def response_count
@response_count ||= @subcategory.measures.map do |measure|
measure.teacher_survey_items.map do |survey_item|
survey_item.survey_item_responses.where(school: @school,
academic_year: @academic_year).exclude_boston.count
survey_item.survey_item_responses.where(school:,
academic_year:).exclude_boston.count
end.sum
end.sum
end
def total_possible_responses
@total_possible_responses ||= begin
total_responses = Respondent.where(school: @school, academic_year: @academic_year).first
total_responses = Respondent.where(school:, academic_year:).first
return 0 unless total_responses.present?
total_responses.total_teachers