mirror of
https://github.com/edcommonwealth/sqm-dashboards.git
synced 2026-03-10 16:00:33 -07:00
fix: correctly load survey items from sample framework file. Fix broken tests
This commit is contained in:
Nelson Jovel
parent
07836cc020
commit
f689ee8ee5
7 changed files with 414 additions and 305 deletions
|
|
@ -1,4 +1,4 @@
|
|||
require 'rails_helper'
|
||||
require "rails_helper"
|
||||
require "#{Rails.root}/app/lib/seeder"
|
||||
|
||||
describe Seeder do
|
||||
|
|
@ -8,58 +8,58 @@ describe Seeder do
|
|||
DatabaseCleaner.clean
|
||||
end
|
||||
|
||||
context 'academic years' do
|
||||
it 'seeds new academic years' do
|
||||
context "academic years" do
|
||||
it "seeds new academic years" do
|
||||
expect do
|
||||
seeder.seed_academic_years '2020-21', '2021-22', '2022-23'
|
||||
seeder.seed_academic_years "2020-21", "2021-22", "2022-23"
|
||||
end.to change { AcademicYear.count }.by(3)
|
||||
expect(AcademicYear.all.map(&:range)).to eq %w[2020-21 2021-22 2022-23]
|
||||
end
|
||||
|
||||
context 'when partial data already exists' do
|
||||
before { create(:academic_year, range: '2020-21') }
|
||||
context "when partial data already exists" do
|
||||
before { create(:academic_year, range: "2020-21") }
|
||||
|
||||
it 'only creates new data' do
|
||||
it "only creates new data" do
|
||||
expect do
|
||||
seeder.seed_academic_years '2020-21', '2021-22'
|
||||
seeder.seed_academic_years "2020-21", "2021-22"
|
||||
end.to change { AcademicYear.count }.by(1)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'districts and schools' do
|
||||
context "districts and schools" do
|
||||
before(:each) do
|
||||
District.delete_all
|
||||
School.delete_all
|
||||
end
|
||||
|
||||
it 'seeds new districts and schools' do
|
||||
it "seeds new districts and schools" do
|
||||
expect do
|
||||
seeder.seed_districts_and_schools sample_districts_and_schools_csv
|
||||
end.to change { District.count }.by(3)
|
||||
.and change { School.count }.by(4)
|
||||
|
||||
high_school = School.find_by_dese_id 160_505
|
||||
expect(high_school.name).to eq 'Attleboro High School'
|
||||
expect(high_school.name).to eq "Attleboro High School"
|
||||
expect(high_school.is_hs).to be true
|
||||
|
||||
elementary_school = School.find_by_dese_id 350_302
|
||||
expect(elementary_school.name).to eq 'Samuel Adams Elementary School'
|
||||
expect(elementary_school.name).to eq "Samuel Adams Elementary School"
|
||||
expect(elementary_school.is_hs).to be false
|
||||
end
|
||||
|
||||
context 'when partial data already exists' do
|
||||
let!(:existing_district) { create(:district, name: 'Boston') }
|
||||
context "when partial data already exists" do
|
||||
let!(:existing_district) { create(:district, name: "Boston") }
|
||||
let!(:removed_school) do
|
||||
create(:school, name: 'John Oldest Academy', dese_id: 12_345, district: existing_district)
|
||||
create(:school, name: "John Oldest Academy", dese_id: 12_345, district: existing_district)
|
||||
end
|
||||
let!(:removed_survey_item_response) { create(:survey_item_response, school: removed_school) }
|
||||
let!(:existing_school) do
|
||||
create(:school, name: 'Sam Adams Elementary School', dese_id: 350_302, slug: 'some-slug-for-sam-adams',
|
||||
create(:school, name: "Sam Adams Elementary School", dese_id: 350_302, slug: "some-slug-for-sam-adams",
|
||||
district: existing_district)
|
||||
end
|
||||
|
||||
it 'only creates new districts and schools' do
|
||||
it "only creates new districts and schools" do
|
||||
expect do
|
||||
seeder.seed_districts_and_schools sample_districts_and_schools_csv
|
||||
end.to change { District.count }.by(2)
|
||||
|
|
@ -67,30 +67,30 @@ describe Seeder do
|
|||
School.count
|
||||
}.by(2) # +2 for schools added from example csv, -1 for old school
|
||||
|
||||
new_district = District.find_by_name 'Attleboro'
|
||||
new_district = District.find_by_name "Attleboro"
|
||||
expect(new_district.qualtrics_code).to eq 1
|
||||
expect(new_district.slug).to eq 'attleboro'
|
||||
expect(new_district.slug).to eq "attleboro"
|
||||
|
||||
new_school = School.find_by_name 'Attleboro High School'
|
||||
new_school = School.find_by_name "Attleboro High School"
|
||||
expect(new_school.dese_id).to eq 160_505
|
||||
expect(new_school.qualtrics_code).to eq 1
|
||||
expect(new_school.slug).to eq 'attleboro-high-school'
|
||||
expect(new_school.slug).to eq "attleboro-high-school"
|
||||
end
|
||||
|
||||
it 'updates existing districts and schools with the correct data' do
|
||||
it "updates existing districts and schools with the correct data" do
|
||||
seeder.seed_districts_and_schools sample_districts_and_schools_csv
|
||||
|
||||
existing_district.reload
|
||||
expect(existing_district.qualtrics_code).to eq 2
|
||||
expect(existing_district.slug).to eq 'boston'
|
||||
expect(existing_district.slug).to eq "boston"
|
||||
|
||||
existing_school.reload
|
||||
expect(existing_school.qualtrics_code).to eq 1
|
||||
expect(existing_school.name).to eq 'Samuel Adams Elementary School'
|
||||
expect(existing_school.slug).to eq 'some-slug-for-sam-adams'
|
||||
expect(existing_school.name).to eq "Samuel Adams Elementary School"
|
||||
expect(existing_school.slug).to eq "some-slug-for-sam-adams"
|
||||
end
|
||||
|
||||
it 'removes any schools and associated child objects not contained within the CSV' do
|
||||
it "removes any schools and associated child objects not contained within the CSV" do
|
||||
seeder.seed_districts_and_schools sample_districts_and_schools_csv
|
||||
|
||||
expect(School.where(id: removed_school)).not_to exist
|
||||
|
|
@ -142,123 +142,123 @@ describe Seeder do
|
|||
# end
|
||||
# end
|
||||
|
||||
context 'admin data items' do
|
||||
context 'when deprecated admin items exist in the database' do
|
||||
context "admin data items" do
|
||||
context "when deprecated admin items exist in the database" do
|
||||
before :each do
|
||||
admin_data_item_1 = create(:admin_data_item, admin_data_item_id: 'a-cppm-i1')
|
||||
admin_data_item_1 = create(:admin_data_item, admin_data_item_id: "a-cppm-i1")
|
||||
create(:admin_data_value, admin_data_item_id: admin_data_item_1.id)
|
||||
admin_data_item_2 = create(:admin_data_item, admin_data_item_id: 'a-ovpe-i2')
|
||||
admin_data_item_2 = create(:admin_data_item, admin_data_item_id: "a-ovpe-i2")
|
||||
create(:admin_data_value, admin_data_item_id: admin_data_item_2.id)
|
||||
admin_data_item_3 = create(:admin_data_item, admin_data_item_id: 'a-phys-i2')
|
||||
admin_data_item_3 = create(:admin_data_item, admin_data_item_id: "a-phys-i2")
|
||||
create(:admin_data_value, admin_data_item_id: admin_data_item_3.id)
|
||||
|
||||
seeder.seed_sqm_framework sample_sqm_framework_csv
|
||||
end
|
||||
|
||||
it 'removes the outdated admin items' do
|
||||
it "removes the outdated admin items" do
|
||||
expect(AdminDataItem.count).to eq 31
|
||||
expect(AdminDataItem.find_by_admin_data_item_id('a-cppm-i1').nil?).to eq true
|
||||
expect(AdminDataItem.find_by_admin_data_item_id('a-ovpe-i2').nil?).to eq true
|
||||
expect(AdminDataItem.find_by_admin_data_item_id('a-phys-i2').nil?).to eq true
|
||||
expect(AdminDataItem.find_by_admin_data_item_id("a-cppm-i1").nil?).to eq true
|
||||
expect(AdminDataItem.find_by_admin_data_item_id("a-ovpe-i2").nil?).to eq true
|
||||
expect(AdminDataItem.find_by_admin_data_item_id("a-phys-i2").nil?).to eq true
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'the sqm framework' do
|
||||
context "the sqm framework" do
|
||||
before do
|
||||
school_culture_category = create(:category, category_id: '2', sort_index: -1)
|
||||
safety_subcategory = create(:subcategory, subcategory_id: '2A', category: school_culture_category)
|
||||
physical_safety_measure = create(:measure, measure_id: '2A-i', subcategory: safety_subcategory)
|
||||
student_physical_safety_scale = create(:scale, scale_id: 's-phys', measure: physical_safety_measure)
|
||||
create(:survey_item, survey_item_id: 's-phys-q1', scale: student_physical_safety_scale)
|
||||
admin_physical_safety_scale = create(:scale, scale_id: 'a-phys', measure: physical_safety_measure)
|
||||
create(:admin_data_item, admin_data_item_id: 'a-phys-i1', scale: admin_physical_safety_scale)
|
||||
school_culture_category = create(:category, category_id: "2", sort_index: -1)
|
||||
safety_subcategory = create(:subcategory, subcategory_id: "2A", category: school_culture_category)
|
||||
physical_safety_measure = create(:measure, measure_id: "2A-i", subcategory: safety_subcategory)
|
||||
student_physical_safety_scale = create(:scale, scale_id: "s-phys", measure: physical_safety_measure)
|
||||
create(:survey_item, survey_item_id: "s-phys-q1", scale: student_physical_safety_scale)
|
||||
admin_physical_safety_scale = create(:scale, scale_id: "a-phys", measure: physical_safety_measure)
|
||||
create(:admin_data_item, admin_data_item_id: "a-phys-i1", scale: admin_physical_safety_scale)
|
||||
end
|
||||
|
||||
it 'creates new objects as necessary' do
|
||||
it "creates new objects as necessary" do
|
||||
expect do
|
||||
seeder.seed_sqm_framework sample_sqm_framework_csv
|
||||
end.to change { Category.count }.by(4)
|
||||
.and change { Subcategory.count }.by(15)
|
||||
.and change { Measure.count }.by(31).and change {
|
||||
Scale.count
|
||||
}.by(51)
|
||||
.and change {
|
||||
SurveyItem.count
|
||||
}.by(136)
|
||||
.and change {
|
||||
AdminDataItem.count
|
||||
}.by(30)
|
||||
}.by(57)
|
||||
.and change {
|
||||
SurveyItem.count
|
||||
}.by(201)
|
||||
.and change {
|
||||
AdminDataItem.count
|
||||
}.by(30)
|
||||
end
|
||||
|
||||
context 'updates records to match given data' do
|
||||
context "updates records to match given data" do
|
||||
before :each do
|
||||
seeder.seed_sqm_framework sample_sqm_framework_csv
|
||||
end
|
||||
|
||||
it 'updates category data' do
|
||||
teachers_leadership = Category.find_by_name 'Teachers & Leadership'
|
||||
it "updates category data" do
|
||||
teachers_leadership = Category.find_by_name "Teachers & Leadership"
|
||||
|
||||
expect(teachers_leadership.slug).to eq 'teachers-and-leadership'
|
||||
expect(teachers_leadership.slug).to eq "teachers-and-leadership"
|
||||
expect(teachers_leadership.description).to eq("Measures the relevant abilities of a school's teachers and the degree to which they are receiving the support they need to grow as professionals. It considers factors like teacher professional qualifications, effective classroom practices, and school-wide support for teaching development and growth.")
|
||||
expect(teachers_leadership.short_description).to eq "Measures the relevant abilities of a school's teachers and the degree to which they are receiving the support they need to grow as professionals."
|
||||
end
|
||||
|
||||
it 'updates category sort index to match a predefined order' do
|
||||
teachers_leadership = Category.find_by_name 'Teachers & Leadership'
|
||||
school_culture = Category.find_by_name 'School Culture'
|
||||
it "updates category sort index to match a predefined order" do
|
||||
teachers_leadership = Category.find_by_name "Teachers & Leadership"
|
||||
school_culture = Category.find_by_name "School Culture"
|
||||
|
||||
expect(teachers_leadership.sort_index).to eq 0
|
||||
expect(school_culture.sort_index).to eq 1
|
||||
end
|
||||
|
||||
it 'updates subcategory data' do
|
||||
subcategory = Subcategory.find_by_name 'Safety'
|
||||
expect(subcategory.description).to eq 'Seeks to determine the degree to which school climate is a safe place for students to learn. It includes measures of student physical safety and student emotional safety.'
|
||||
it "updates subcategory data" do
|
||||
subcategory = Subcategory.find_by_name "Safety"
|
||||
expect(subcategory.description).to eq "Seeks to determine the degree to which school climate is a safe place for students to learn. It includes measures of student physical safety and student emotional safety."
|
||||
end
|
||||
|
||||
it 'updates measure data' do
|
||||
measure = Measure.find_by_measure_id '2A-i'
|
||||
expect(measure.name).to eq 'Student Physical Safety'
|
||||
expect(measure.description).to eq 'Draws on anonymous student reports about the degree to which they feel physically safe at school. It also measures the use of exclusionary discipline at the school.'
|
||||
it "updates measure data" do
|
||||
measure = Measure.find_by_measure_id "2A-i"
|
||||
expect(measure.name).to eq "Student Physical Safety"
|
||||
expect(measure.description).to eq "Draws on anonymous student reports about the degree to which they feel physically safe at school. It also measures the use of exclusionary discipline at the school."
|
||||
end
|
||||
|
||||
it 'updates scale references' do
|
||||
scale = Scale.find_by_scale_id 't-pcom'
|
||||
measure = Measure.find_by_measure_id '1A-iii'
|
||||
survey_item = SurveyItem.find_by_survey_item_id 't-pcom-q1'
|
||||
it "updates scale references" do
|
||||
scale = Scale.find_by_scale_id "t-pcom"
|
||||
measure = Measure.find_by_measure_id "1A-iii"
|
||||
survey_item = SurveyItem.find_by_survey_item_id "t-pcom-q1"
|
||||
expect(scale.measure).to eq measure
|
||||
expect(scale.survey_items).to include survey_item
|
||||
end
|
||||
|
||||
it 'does not overwrite the survey item benchmarks with admin data benchmarks' do
|
||||
survey_item = SurveyItem.find_by_survey_item_id 't-prep-q1'
|
||||
it "does not overwrite the survey item benchmarks with admin data benchmarks" do
|
||||
survey_item = SurveyItem.find_by_survey_item_id "t-prep-q1"
|
||||
expect(survey_item.approval_low_benchmark).to eq 3.5
|
||||
end
|
||||
|
||||
it 'updates survey item data' do
|
||||
survey_item = SurveyItem.find_by_survey_item_id 's-phys-q1'
|
||||
expect(survey_item.prompt).to eq 'How often do you worry about violence at your school?'
|
||||
it "updates survey item data" do
|
||||
survey_item = SurveyItem.find_by_survey_item_id "s-phys-q1"
|
||||
expect(survey_item.prompt).to eq "How often do you worry about violence at your school?"
|
||||
expect(survey_item.watch_low_benchmark).to eq 2.79
|
||||
expect(survey_item.growth_low_benchmark).to eq 3.3
|
||||
expect(survey_item.approval_low_benchmark).to eq 3.8
|
||||
expect(survey_item.ideal_low_benchmark).to eq 4.51
|
||||
expect(survey_item.on_short_form).to eq false
|
||||
|
||||
short_form_item = SurveyItem.find_by_survey_item_id 's-peff-q6'
|
||||
short_form_item = SurveyItem.find_by_survey_item_id "s-peff-q6"
|
||||
expect(short_form_item.on_short_form).to eq true
|
||||
end
|
||||
|
||||
it 'updates admin data item data' do
|
||||
admin_data_item = AdminDataItem.find_by_admin_data_item_id 'a-phys-i1'
|
||||
it "updates admin data item data" do
|
||||
admin_data_item = AdminDataItem.find_by_admin_data_item_id "a-phys-i1"
|
||||
expect(admin_data_item.watch_low_benchmark).to eq 2.99
|
||||
expect(admin_data_item.growth_low_benchmark).to eq 3.5
|
||||
expect(admin_data_item.approval_low_benchmark).to eq 4
|
||||
expect(admin_data_item.ideal_low_benchmark).to eq 4.71
|
||||
expect(admin_data_item.description).to eq 'Percent of students suspended'
|
||||
expect(admin_data_item.description).to eq "Percent of students suspended"
|
||||
expect(admin_data_item.hs_only_item).to be false
|
||||
|
||||
hs_admin_data_item = AdminDataItem.find_by_admin_data_item_id 'a-curv-i1'
|
||||
hs_admin_data_item = AdminDataItem.find_by_admin_data_item_id "a-curv-i1"
|
||||
expect(hs_admin_data_item.hs_only_item).to be true
|
||||
end
|
||||
end
|
||||
|
|
@ -267,10 +267,10 @@ describe Seeder do
|
|||
private
|
||||
|
||||
def sample_districts_and_schools_csv
|
||||
Rails.root.join('spec', 'fixtures', 'sample_districts_and_schools.csv')
|
||||
Rails.root.join("spec", "fixtures", "sample_districts_and_schools.csv")
|
||||
end
|
||||
|
||||
def sample_sqm_framework_csv
|
||||
Rails.root.join('spec', 'fixtures', 'sample_sqm_framework.csv')
|
||||
Rails.root.join("spec", "fixtures", "sample_sqm_framework.csv")
|
||||
end
|
||||
end
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue