gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-09 07:28:41 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: correctly memoize student_survey_items_with_sufficient_responses so that on the analyze page, when the first year has insufficient responses, it doesn't affect all subsequent years

Browse source
This commit is contained in:
Nelson Jovel 2024-06-12 16:28:15 -07:00
parent 4d5b7969a9
commit ebcb27ca6d
4 changed files with 32 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/models/measure.rb
View file

@ -25,8 +25,8 @@ class Measure < ActiveRecord::Base
end
def student_survey_items_with_sufficient_responses(school:, academic_year:)
@student_survey_items_with_sufficient_responses ||=
SurveyItem.where(id: SurveyItem.joins('inner join survey_item_responses on survey_item_responses.survey_item_id = survey_items.id')
@student_survey_items_with_sufficient_responses ||= Hash.new do |memo, (school, academic_year)|
memo[[school, academic_year]] = SurveyItem.where(id: SurveyItem.joins("inner join survey_item_responses on survey_item_responses.survey_item_id = survey_items.id")
.student_survey_items
.where("survey_item_responses.school": school,
"survey_item_responses.academic_year": academic_year,
@ -34,6 +34,8 @@ class Measure < ActiveRecord::Base
.group('survey_items.id')
.having('count(*) >= 10')
.count.keys)
end
@student_survey_items_with_sufficient_responses[[school, academic_year]]
end
def teacher_scales