fix: failing tests

This commit is contained in:
Nelson Jovel 2024-11-08 15:56:56 -08:00
parent beb93aa8e8
commit eb6fde5f88
7 changed files with 71 additions and 57 deletions

View file

@ -36,15 +36,15 @@ class Overview::OverviewPresenter
end
def student_response_rate_presenter
StudentResponseRatePresenter.new(focus: :student, school: @school, academic_year: @academic_year)
StudentResponseRatePresenter.new(school: @school, academic_year: @academic_year)
end
def teacher_response_rate_presenter
TeacherResponseRatePresenter.new(focus: :teacher, school: @school, academic_year: @academic_year)
TeacherResponseRatePresenter.new(school: @school, academic_year: @academic_year)
end
def parent_response_rate_presenter
ParentResponseRatePresenter.new(focus: :parent, school: @school, academic_year: @academic_year)
ParentResponseRatePresenter.new(school: @school, academic_year: @academic_year)
end
def presenter_for_measure(measure)

View file

@ -1,6 +1,6 @@
class ParentResponseRatePresenter < ResponseRatePresenter
def initialize(focus:, academic_year:, school:)
super(focus:, academic_year:, school:)
def initialize(academic_year:, school:)
super(academic_year:, school:)
@survey_items = SurveyItem.parent_survey_items if focus == :parent
end
@ -17,4 +17,8 @@ class ParentResponseRatePresenter < ResponseRatePresenter
respondents.total_students
end
def focus
"parent"
end
end

View file

@ -1,8 +1,7 @@
class ResponseRatePresenter
attr_reader :focus, :academic_year, :school, :survey_items
attr_reader :academic_year, :school, :survey_items
def initialize(focus:, academic_year:, school:)
@focus = focus
def initialize(academic_year:, school:)
@academic_year = academic_year
@school = school
end
@ -34,6 +33,10 @@ class ResponseRatePresenter
"Percentages based on #{actual_count} out of #{respondents_count.round} #{focus}s completing at least 25% of the survey."
end
def focus
raise "please implment method: focus"
end
private
def cap_at_100(value)

View file

@ -1,6 +1,6 @@
class StudentResponseRatePresenter < ResponseRatePresenter
def initialize(focus:, academic_year:, school:)
super(focus:, academic_year:, school:)
def initialize(academic_year:, school:)
super(academic_year:, school:)
@survey_items = Measure.all.flat_map do |measure|
measure.student_survey_items_with_sufficient_responses(school:, academic_year:)
end
@ -35,4 +35,8 @@ class StudentResponseRatePresenter < ResponseRatePresenter
enrollment
end
def focus
"student"
end
end

View file

@ -1,6 +1,6 @@
class TeacherResponseRatePresenter < ResponseRatePresenter
def initialize(focus:, academic_year:, school:)
super(focus:, academic_year:, school:)
def initialize(academic_year:, school:)
super(academic_year:, school:)
@survey_items = SurveyItem.teacher_survey_items
end
@ -13,4 +13,8 @@ class TeacherResponseRatePresenter < ResponseRatePresenter
respondents.total_teachers
end
def focus
"teacher"
end
end