gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-10 16:00:33 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add popup message on admin data exclamation point indicators

Browse source
This commit is contained in:
rebuilt 2022-07-07 18:47:51 -07:00
parent deaf13c976
commit ea09fa06b7
4 changed files with 12 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

9
app/models/measure.rb
View file

@ -204,10 +204,8 @@ class Measure < ActiveRecord::Base
def sufficient_student_data?(school:, academic_year:)
return @sufficient_student_data ||= false unless includes_student_survey_items?
return @sufficient_student_data ||= false if student_survey_items_by_survey_type(school:,
academic_year:).all? do |survey_item|
survey_item.survey_item_responses.where(school:,
academic_year:).none?
return @sufficient_student_data ||= false if student_survey_items_by_survey_type(school:, academic_year:).all? do |survey_item|
survey_item.survey_item_responses.where(school:, academic_year:).none?
end
@sufficient_student_data ||= subcategory.response_rate(school:, academic_year:).meets_student_threshold?
@ -216,8 +214,7 @@ class Measure < ActiveRecord::Base
def sufficient_teacher_data?(school:, academic_year:)
return @sufficient_teacher_data ||= false unless includes_teacher_survey_items?
return @sufficient_teacher_data ||= false if teacher_survey_items.all? do |survey_item|
survey_item.survey_item_responses.where(school:,
academic_year:).none?
survey_item.survey_item_responses.where(school:, academic_year:).none?
end
@sufficient_teacher_data ||= subcategory.response_rate(school:, academic_year:).meets_teacher_threshold?

4
app/presenters/student_survey_presenter.rb
View file

@ -1,4 +1,6 @@
class StudentSurveyPresenter < DataItemPresenter
attr_reader :survey_items
def initialize(measure_id:, survey_items:, has_sufficient_data:, school:, academic_year:)
super(measure_id:, has_sufficient_data:, school:, academic_year:)
@survey_items = survey_items
@ -21,7 +23,7 @@ class StudentSurveyPresenter < DataItemPresenter
end
def descriptions_and_availability
@survey_items.map do |survey_item|
survey_items.map do |survey_item|
DataAvailability.new(survey_item.survey_item_id, survey_item.prompt, true)
end
end

4
app/presenters/teacher_survey_presenter.rb
View file

@ -1,4 +1,6 @@
class TeacherSurveyPresenter < DataItemPresenter
attr_reader :survey_items
def initialize(measure_id:, survey_items:, has_sufficient_data:, school:, academic_year:)
super(measure_id:, has_sufficient_data:, school:, academic_year:)
@survey_items = survey_items
@ -23,7 +25,7 @@ class TeacherSurveyPresenter < DataItemPresenter
end
def descriptions_and_availability
@survey_items.map do |survey_item|
survey_items.map do |survey_item|
DataAvailability.new(survey_item.survey_item_id, survey_item.prompt, true)
end
end

4
app/views/categories/_data_item_section.html.erb
View file

@ -30,7 +30,9 @@
<% data_item_section.descriptions_and_availability.each do |data| %>
<li><%= data.description %>
<% unless data.available? %>
&nbsp;<i class="fa-solid fa-circle-exclamation" data-missing-data="<%= data.id %>"></i>
&nbsp;<i class="fa-solid fa-circle-exclamation" data-missing-data="<%= data.id %>"
data-bs-toggle="popover" data-bs-placement="right"
data-bs-content="Data not included due to limited availability"></i>
<% end %>
</li>
<% end %>