From e203be056aa2777fce8fbc9b3779b0b009961e5b Mon Sep 17 00:00:00 2001 From: Nelson Jovel Date: Wed, 6 Dec 2023 14:58:56 -0800 Subject: [PATCH] chore: refactor code so we use a hash instead of a switch statement for long-term performance --- app/models/income.rb | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/app/models/income.rb b/app/models/income.rb index 96bf969f..2402876c 100644 --- a/app/models/income.rb +++ b/app/models/income.rb @@ -6,17 +6,6 @@ class Income < ApplicationRecord friendly_id :designation, use: [:slugged] - def label - case designation - when "Economically Disadvantaged - Y" - "Economically Disadvantaged" - when "Economically Disadvantaged - N" - "Not Economically Disadvantaged" - when "Unknown" - "Unknown" - end - end - def self.to_designation(income) case income in /Free\s*Lunch|Reduced\s*Lunch|Low\s*Income|Reduced\s*price\s*lunch/i @@ -27,4 +16,14 @@ class Income < ApplicationRecord "Unknown" end end + + LABELS = { + "Economically Disadvantaged - Y" => "Economically Disadvantaged", + "Economically Disadvantaged - N" => "Not Economically Disadvantaged", + "Unknown" => "Unknown" + } + + def label + LABELS[designation] + end end