<% unless data_item_section.sufficient_data? %>
-
+
Data not included due to <%= data_item_section.reason_for_insufficiency %>
<% end %>
- <% data_item_section.item_descriptions.each do |description| %>
- - <%= description %>
+ <% data_item_section.descriptions_and_availability.each do |data| %>
+ - <%= data.description %>
+ <% unless data.available? %>
+
+ <% end %>
+
<% end %>
diff --git a/spec/fixtures/sample_admin_data.csv b/spec/fixtures/sample_admin_data.csv
index 689ec5d1..48658e21 100644
--- a/spec/fixtures/sample_admin_data.csv
+++ b/spec/fixtures/sample_admin_data.csv
@@ -10,5 +10,4 @@ Winchester,Winchester High School,3440505,3-A-i,a-reso-i1,Average class size,17,
Attleboro,Attleboro High School,160505,3-A-ii,a-sust-i3,Student to instructional support staff ratio,15.28896673,0.4,43.4,,2018-19
Milford,Woodland Elementary School,1850090,3-A-ii,a-sust-i3,Student to instructional support staff ratio,22.85714286,2.106649112,43.4,,2018-19
Revere,Beachmont Elementary School,2480013,3-A-ii,a-sust-i3,Student to instructional support staff ratio,38,3.5,43.4,,2018-19
-Winchester,Winchester High School,3440505,3-A-ii,a-sust-i3,Student to instructional support staff ratio,135.9,5,43.4,,2018-19
-Attleboro,Attleboro High School,160505,3-A-i,a-sust-i3,Average class size,20.6,100,20,,2018-19
+Winchester,Winchester High School,3440505,3-A-ii,a-sust-i3,Student to instructional support staff ratio,135.9,100,43.4,,2018-19
diff --git a/spec/presenters/data_item_presenters/admin_data_presenter_spec.rb b/spec/presenters/data_item_presenters/admin_data_presenter_spec.rb
new file mode 100644
index 00000000..44069644
--- /dev/null
+++ b/spec/presenters/data_item_presenters/admin_data_presenter_spec.rb
@@ -0,0 +1,77 @@
+require 'rails_helper'
+
+describe AdminDataPresenter do
+ let(:school) { School.find_by_slug 'milford-high-school' }
+ let(:academic_year) { AcademicYear.find_by_range '2021-22' }
+ let(:measure_1A_i) { Measure.find_by_measure_id '1A-i' }
+ let(:measure_1A_iii) { Measure.find_by_measure_id '1A-iii' }
+ describe '#item_description' do
+ before :each do
+ Rails.application.load_seed
+ end
+
+ after :each do
+ DatabaseCleaner.clean
+ end
+
+ context 'When the presenter is based on measure 1A-1' do
+ it 'returns a list of survey prompts for teacher survey items' do
+ expect(AdminDataPresenter.new(measure_id: measure_1A_i.measure_id, admin_data_items: measure_1A_i.admin_data_items,
+ has_sufficient_data: true, school:, academic_year:).item_descriptions).to eq [
+ 'Percentage teachers with 5+ years of experience', 'Percentage teachers National Board certified', 'Percentage teachers teaching in area of licensure'
+ ]
+ end
+ context 'When the measure is missing all admin data values' do
+ it 'if it lacks sufficient data, it shows a warning ' do
+ expect(AdminDataPresenter.new(measure_id: measure_1A_i.measure_id, admin_data_items: measure_1A_i.admin_data_items,
+ has_sufficient_data: false, school:, academic_year:).sufficient_data?).to eq false
+ end
+ end
+
+ context 'When the measure has at least one admin data value' do
+ it 'if it lacks sufficient data, it doesnt show a warning ' do
+ expect(AdminDataPresenter.new(measure_id: measure_1A_i.measure_id, admin_data_items: measure_1A_i.admin_data_items,
+ has_sufficient_data: true, school:, academic_year:).sufficient_data?).to eq true
+ end
+ end
+ end
+
+ context 'When the presenter is based on measure 1A-iii' do
+ it 'returns a message hiding the actual prompts. Instead it presents a message telling the user they can ask for more information' do
+ expect(AdminDataPresenter.new(measure_id: measure_1A_iii.measure_id, admin_data_items: measure_1A_iii.admin_data_items,
+ has_sufficient_data: true, school:, academic_year:).item_descriptions).to eq [
+ 'Percent teacher returning (excluding retirement)', 'Percent teachers with 10+ days absent'
+ ]
+ end
+ end
+ end
+
+ describe '#descriptions_and_availibility' do
+ before :each do
+ Rails.application.load_seed
+ end
+
+ after :each do
+ DatabaseCleaner.clean
+ end
+ context 'when there are any matching values for admin data items' do
+ before do
+ admin_data_item = measure_1A_i.admin_data_items.first
+ create(:admin_data_value, admin_data_item:, school:, academic_year:)
+ end
+ it 'returns a list of admin data items and whether there is a matching value' do
+ expect(
+ AdminDataPresenter.new(
+ measure_id: measure_1A_i.measure_id, admin_data_items: measure_1A_i.admin_data_items, has_sufficient_data: true, school:, academic_year:
+ ).descriptions_and_availability
+ ).to eq [
+ DataAvailability.new('a-exp-i1', 'Percentage teachers with 5+ years of experience', true),
+ DataAvailability.new('a-exp-i2', 'Percentage teachers National Board certified', false),
+ DataAvailability.new('a-exp-i3', 'Percentage teachers teaching in area of licensure', false)
+ ]
+ end
+ end
+ context 'when there are NO matching values for admin data items' do
+ end
+ end
+end
diff --git a/spec/presenters/data_item_presenters/teacher_survey_presenter_spec.rb b/spec/presenters/data_item_presenters/teacher_survey_presenter_spec.rb
index 2d80d20b..d3a2fa45 100644
--- a/spec/presenters/data_item_presenters/teacher_survey_presenter_spec.rb
+++ b/spec/presenters/data_item_presenters/teacher_survey_presenter_spec.rb
@@ -1,8 +1,11 @@
require 'rails_helper'
describe TeacherSurveyPresenter do
+ let(:school) { School.first }
+ let(:academic_year) { AcademicYear.first }
let(:measure_1A_i) { Measure.find_by_measure_id '1A-i' }
let(:measure_1B_i) { Measure.find_by_measure_id '1B-i' }
+
describe '#item_description' do
before :each do
Rails.application.load_seed
@@ -15,7 +18,7 @@ describe TeacherSurveyPresenter do
context 'When the presenter is based on measure 1A-1' do
it 'returns a list of survey prompts for teacher survey items' do
expect(TeacherSurveyPresenter.new(measure_id: measure_1A_i.measure_id, survey_items: measure_1A_i.teacher_survey_items,
- has_sufficient_data: true).item_descriptions).to eq [
+ has_sufficient_data: true, school:, academic_year:).item_descriptions).to eq [
'Given your preparation for teaching how comfortable are you teaching at the grade-level you have been assigned?',
'How prepared are you for teaching the topics that you are expected to teach in your assignment?',
'How confident are you in working with the student body at your school?'
@@ -26,7 +29,7 @@ describe TeacherSurveyPresenter do
context 'When the presenter is based on measure 1B-i' do
it 'returns a message hiding the actual prompts. Instead it presents a message telling the user they can ask for more information' do
expect(TeacherSurveyPresenter.new(measure_id: measure_1B_i.measure_id, survey_items: measure_1B_i.teacher_survey_items,
- has_sufficient_data: true).item_descriptions).to eq [
+ has_sufficient_data: true, school:, academic_year:).item_descriptions).to eq [
'Items available upon request to MCIEA.'
]
end
diff --git a/spec/services/admin_data_loader_spec.rb b/spec/services/admin_data_loader_spec.rb
index 975a3fe8..0e01b8a4 100644
--- a/spec/services/admin_data_loader_spec.rb
+++ b/spec/services/admin_data_loader_spec.rb
@@ -5,6 +5,7 @@ describe AdminDataLoader do
let(:ay_2018_19) { AcademicYear.find_by_range '2018-19' }
let(:attleboro) { School.find_by_dese_id 160_505 }
let(:winchester) { School.find_by_dese_id 3_440_505 }
+ let(:beachmont) { School.find_by_dese_id 2_480_013 }
let(:chronic_absense_rate) { AdminDataItem.find_by_admin_data_item_id 'a-vale-i1' }
let(:student_to_instructor_ratio) { AdminDataItem.find_by_admin_data_item_id 'a-sust-i3' }
@@ -28,7 +29,7 @@ describe AdminDataLoader do
# it 'assigns the school to the admin data value' do
expect(AdminDataValue.first.school).to eq attleboro
- expect(AdminDataValue.last.school).to eq winchester
+ expect(AdminDataValue.last.school).to eq beachmont
# end
# it 'links the admin data value to the correct admin data item' do
@@ -37,12 +38,14 @@ describe AdminDataLoader do
# end
# it 'loads all the admin data values in the target csv file' do
- expect(AdminDataValue.count).to eq 11
+ expect(AdminDataValue.count).to eq 10
# end
# it 'captures the likert score ' do
- expect(AdminDataValue.first.likert_score).to eq 3.03
- expect(AdminDataValue.last.likert_score).to eq 5
+ expect(AdminDataValue.find_by(school: attleboro, academic_year: ay_2018_19,
+ admin_data_item: chronic_absense_rate).likert_score).to eq 3.03
+ expect(AdminDataValue.find_by(school: beachmont, academic_year: ay_2018_19,
+ admin_data_item: student_to_instructor_ratio).likert_score).to eq 3.5
# end
# it 'rounds up any likert_scores between 0 and 1 (non-inclusive) to 1' do
@@ -52,7 +55,7 @@ describe AdminDataLoader do
# it 'rejects importing rows with a value of 0' do
expect(AdminDataValue.where(school: attleboro, academic_year: ay_2018_19,
admin_data_item: AdminDataItem.find_by_admin_data_item_id('a-reso-i1'))).not_to exist
- expect(AdminDataValue.where(school: attleboro, academic_year: ay_2018_19,
+ expect(AdminDataValue.where(school: winchester, academic_year: ay_2018_19,
admin_data_item: AdminDataItem.find_by_admin_data_item_id('a-sust-i3'))).not_to exist
# end
end
diff --git a/spec/views/analyze/index.html.erb_spec.rb b/spec/views/analyze/index.html.erb_spec.rb
index 3e73ea04..1f63341e 100644
--- a/spec/views/analyze/index.html.erb_spec.rb
+++ b/spec/views/analyze/index.html.erb_spec.rb
@@ -60,7 +60,6 @@ describe 'analyze/index' do
render
end
-
context 'when all the presenters have a nil score' do
# let(:grouped_bar_column_presenters) do
# measure = create(:measure, name: 'Display Me', measure_id: 'display-me')
@@ -114,7 +113,4 @@ describe 'analyze/index' do
expect(year_checkbox).to have_attribute 'disabled'
end
end
-
- context 'when presenters have a score' do
- end
end
diff --git a/spec/views/categories/show.html.erb_spec.rb b/spec/views/categories/show.html.erb_spec.rb
index c1b91ae6..7ee93821 100644
--- a/spec/views/categories/show.html.erb_spec.rb
+++ b/spec/views/categories/show.html.erb_spec.rb
@@ -2,41 +2,71 @@ require 'rails_helper'
include GaugeHelper
describe 'categories/show' do
+ subject { Nokogiri::HTML(rendered) }
+ let(:academic_year) { create(:academic_year, range: '1989-90') }
+ let(:school) { create(:school, name: 'Best School') }
+ let(:category) { create(:category, name: 'Some Category', description: 'Some description of the category') }
+ let(:category_presenter) { CategoryPresenter.new(category:) }
+ let(:subcategory1) do
+ create(:subcategory, category:, name: 'A subcategory', description: 'Some description of the subcategory')
+ end
+ let(:subcategory2) do
+ create(:subcategory, category:, name: 'Another subcategory',
+ description: 'Another description of the subcategory')
+ end
+ let(:measure1) { create(:measure, subcategory: subcategory1) }
+ let(:scale1) { create(:student_scale, measure: measure1) }
+ let(:survey_item1) do
+ create(:student_survey_item, scale: scale1, watch_low_benchmark: 1.5, growth_low_benchmark: 2.5,
+ approval_low_benchmark: 3.5, ideal_low_benchmark: 4.5)
+ end
+ let(:measure2) do
+ create(:measure, name: 'The second measure name', description: 'The second measure description', measure_id: '1A-i',
+ subcategory: subcategory2)
+ end
+ let(:scale2) { create(:student_scale, measure: measure2) }
+ let(:scale3) { create(:teacher_scale, measure: measure2) }
+ let(:student_survey_item) do
+ create(:student_survey_item, scale: scale2, prompt: 'Some prompt for student data',
+ watch_low_benchmark: 1.5, growth_low_benchmark: 2.5, approval_low_benchmark: 3.5, ideal_low_benchmark: 4.5)
+ end
+ let(:teacher_survey_item) { create(:teacher_survey_item, scale: scale3, prompt: 'Some prompt for teacher data') }
+ let(:admin_data_scale) { create(:scale, measure: measure2) }
+ let(:admin_data_item) do
+ create(:admin_data_item, scale: admin_data_scale, description: 'Some admin data item description',
+ watch_low_benchmark: 1.5, growth_low_benchmark: 2.5, approval_low_benchmark: 3.5, ideal_low_benchmark: 4.5)
+ end
+
before :each do
- academic_year = create(:academic_year, range: '1989-90')
- school = create(:school, name: 'Best School')
+ academic_year
+ school
- category = create(:category, name: 'Some Category', description: 'Some description of the category')
- category_presenter = CategoryPresenter.new(category:)
+ category
+ category_presenter
- subcategory1 = create(:subcategory, category:, name: 'A subcategory',
- description: 'Some description of the subcategory')
- subcategory2 = create(:subcategory, category:, name: 'Another subcategory',
- description: 'Another description of the subcategory')
+ subcategory1
+ subcategory2
- measure1 = create(:measure, subcategory: subcategory1)
- scale1 = create(:student_scale, measure: measure1)
- survey_item1 = create(:student_survey_item, scale: scale1, watch_low_benchmark: 1.5, growth_low_benchmark: 2.5,
- approval_low_benchmark: 3.5, ideal_low_benchmark: 4.5)
+ measure1
+ scale1
+ survey_item1
create_list(:survey_item_response, SurveyItemResponse::STUDENT_RESPONSE_THRESHOLD, survey_item: survey_item1,
academic_year:, school:, likert_score: 3)
- measure2 = create(:measure, name: 'The second measure name', description: 'The second measure description',
- subcategory: subcategory2)
- scale2 = create(:student_scale, measure: measure2)
- scale3 = create(:teacher_scale, measure: measure2)
- student_survey_item = create(:student_survey_item, scale: scale2, prompt: 'Some prompt for student data',
- watch_low_benchmark: 1.5, growth_low_benchmark: 2.5, approval_low_benchmark: 3.5, ideal_low_benchmark: 4.5)
+ measure2
+ scale2
+ scale3
+ student_survey_item
create_list(:survey_item_response, SurveyItemResponse::STUDENT_RESPONSE_THRESHOLD,
survey_item: student_survey_item, academic_year:, school:, likert_score: 5)
- teacher_survey_item = create(:teacher_survey_item, scale: scale3, prompt: 'Some prompt for teacher data')
+ teacher_survey_item
create_list(:survey_item_response, SurveyItemResponse::TEACHER_RESPONSE_THRESHOLD,
survey_item: teacher_survey_item, academic_year:, school:, likert_score: 3)
- admin_data_scale = create(:scale, measure: measure2)
- create(:admin_data_item, scale: admin_data_scale, description: 'Some admin data item description',
- watch_low_benchmark: 1.5, growth_low_benchmark: 2.5, approval_low_benchmark: 3.5, ideal_low_benchmark: 4.5)
+ admin_data_scale
+ admin_data_item
+
assign :category, category_presenter
assign :categories, [category_presenter]
@@ -47,15 +77,22 @@ describe 'categories/show' do
create(:respondent, school:, academic_year:)
create(:survey, school:, academic_year:)
- render
end
- it 'renders the category name and description' do
- expect(rendered).to match(/Some Category/)
- expect(rendered).to match(/Some description of the category/)
+ context 'for each category' do
+ before do
+ render
+ end
+ it 'renders the category name and description' do
+ expect(rendered).to match(/Some Category/)
+ expect(rendered).to match(/Some description of the category/)
+ end
end
context 'for each subcategory' do
+ before do
+ render
+ end
it 'renders the subcategory name' do
expect(rendered).to match(/A subcategory/)
expect(rendered).to match(/Another subcategory/)
@@ -73,6 +110,9 @@ describe 'categories/show' do
end
context 'for each measure' do
+ before do
+ render
+ end
it 'renders the measure name' do
expect(rendered).to match(/The second measure name/)
end
@@ -92,4 +132,43 @@ describe 'categories/show' do
expect(rendered).to match(/Some admin data item description/)
end
end
+
+ context 'when the measure does NOT have admin data values' do
+ before do
+ render
+ end
+ it 'renders the insufficient data exclamation point icon' do
+ exclamation_points = subject.css('[data-exclamation-point]')
+ expect(exclamation_points.first.attribute('data-exclamation-point').value).to eq 'admin-data-items-1A-i'
+ end
+ it 'renders the insufficient data message' do
+ exclamation_points = subject.css('[data-insufficient-data-message]')
+ expect(exclamation_points.first.attribute('data-insufficient-data-message').value).to eq 'admin-data-items-1A-i-limited availability'
+ end
+ it 'renders the insufficient data exclamation point icons next to the description of the missing admin data item' do
+ exclamation_points = subject.css('[data-missing-data]')
+ expect(exclamation_points.first.attribute('data-missing-data').value).to eq "#{admin_data_item.admin_data_item_id}"
+ end
+ end
+
+ context 'when the measure DOES have admin data values' do
+ before :each do
+ create(:admin_data_value, admin_data_item:, school:, academic_year:, likert_score: 2)
+ render
+ end
+ it 'does not render the insufficient data exclamation point icon' do
+ exclamation_points = subject.css('[data-exclamation-point]')
+ expect(exclamation_points.count).to eq 0
+ end
+
+ it 'does not render the insufficient data message ' do
+ exclamation_points = subject.css('[data-insufficient-data-message]')
+ expect(exclamation_points.count).to eq 0
+ end
+
+ it 'Does NOT render the insufficient data exclamation point icons next to the description of the missing admin data item' do
+ exclamation_points = subject.css('[data-missing-data]')
+ expect(exclamation_points.count).to eq 0
+ end
+ end
end