gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-08 23:18:18 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Address bug related to story #182855028

Browse source
This commit is contained in:
rebuilt 2022-07-29 16:04:43 -07:00
parent 12e4e3f177
commit d44a5275b4
3 changed files with 2765 additions and 2694 deletions
Download patch file Download diff file Expand all files Collapse all files

11
app/models/measure.rb
View file

@ -183,18 +183,17 @@ class Measure < ActiveRecord::Base
end
def sufficient_student_data?(school:, academic_year:)
false unless includes_student_survey_items?
false if no_student_responses_exist?(school:, academic_year:)
return false unless includes_student_survey_items?
return false if no_student_responses_exist?(school:, academic_year:)
# this gets memoized on first run so check to make sure
subcategory.response_rate(school:, academic_year:).meets_student_threshold?
end
def sufficient_teacher_data?(school:, academic_year:)
return @sufficient_teacher_data ||= false unless includes_teacher_survey_items?
return @sufficient_teacher_data ||= false if no_teacher_responses_exist?(school:, academic_year:)
return false unless includes_teacher_survey_items?
return false if no_teacher_responses_exist?(school:, academic_year:)
@sufficient_teacher_data ||= subcategory.response_rate(school:, academic_year:).meets_teacher_threshold?
subcategory.response_rate(school:, academic_year:).meets_teacher_threshold?
end
def no_student_responses_exist?(school:, academic_year:)