gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-07 21:48:16 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove authentication check. Finishes #181920761

Browse source
This commit is contained in:
Nelson Jovel 2022-04-21 12:26:08 -07:00
parent c49dee0a63
commit cbc8ba59ba
2 changed files with 0 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

9
app/controllers/sqm_application_controller.rb
View file

@ -1,7 +1,6 @@
class SqmApplicationController < ApplicationController class SqmApplicationController < ApplicationController
protect_from_forgery with: :exception, prepend: true protect_from_forgery with: :exception, prepend: true
before_action :set_schools_and_districts before_action :set_schools_and_districts
before_action :authenticate_district
private private
@ -28,12 +27,4 @@ class SqmApplicationController < ApplicationController
def school_slug def school_slug
params[:school_id] params[:school_id]
end end
def authenticate(username, password)
return true if username == 'boston'
authenticate_or_request_with_http_basic do |u, p|
u == username && p == password
end
end
end end

43
spec/system/authentication_spec.rb
View file

@ -1,43 +0,0 @@
require 'rails_helper'
describe 'authentication' do
let(:district) { create(:district) }
let(:school) { create(:school, district:) }
let(:academic_year) { create(:academic_year) }
context 'when using the wrong credentials' do
before :each do
page.driver.browser.basic_authorize('wrong username', 'wrong password')
end
it 'does not show any information' do
visit overview_path
expect(page).not_to have_text(school.name)
end
end
context 'when using the right credentials' do
before :each do
page.driver.browser.basic_authorize(username, password)
end
it 'does show information' do
visit overview_path
expect(page).to have_text(school.name)
end
end
private
def username
district.name.downcase
end
def password
"#{username}!"
end
def overview_path
district_school_overview_index_path(district, school, year: academic_year.range)
end
end