gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-08 23:18:18 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Do not count empty survey items in response rate calculations. Fixes #181922483

Browse source
This commit is contained in:
Nelson Jovel 2022-04-29 07:40:47 -07:00
parent 15431b09bb
commit c2e40fed8d
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/models/student_response_rate.rb
View file

@ -9,7 +9,9 @@ class StudentResponseRate
survey_items = SurveyItem.includes(%i[scale
measure]).student_survey_items.where("scale.measure": @subcategory.measures)
survey_items = survey_items.where(on_short_form: true) if survey.form == 'short'
survey_items = survey_items.reject { |survey_item| survey_item.survey_item_responses.count == 0 }
survey_items = survey_items.reject do |survey_item|
survey_item.survey_item_responses.where(school: @school, academic_year: @academic_year).count == 0
end
survey_items.count
end
end