mirror of
https://github.com/edcommonwealth/sqm-dashboards.git
synced 2026-03-07 21:48:16 -08:00
Finishes #180264854. Prevents empty dataset modal from displaying on browse page
This commit is contained in:
parent
b45dca7a5a
commit
bde992c96b
3 changed files with 10 additions and 7 deletions
|
|
@ -90,3 +90,5 @@
|
||||||
|
|
||||||
<%= render partial: "variance_chart", locals: { presenters: @variance_chart_row_presenters} %>
|
<%= render partial: "variance_chart", locals: { presenters: @variance_chart_row_presenters} %>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
<%= render partial: 'layouts/empty_dataset_modal' if @has_empty_dataset %>
|
||||||
|
|
|
||||||
|
|
@ -33,7 +33,5 @@
|
||||||
<%= render partial: 'layouts/footer' %>
|
<%= render partial: 'layouts/footer' %>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<%= render partial: 'layouts/empty_dataset_modal' if @has_empty_dataset %>
|
|
||||||
|
|
||||||
</body>
|
</body>
|
||||||
</html>
|
</html>
|
||||||
|
|
|
||||||
|
|
@ -13,11 +13,14 @@ describe 'SQM Application' do
|
||||||
end
|
end
|
||||||
|
|
||||||
context 'when no measures meet their threshold' do
|
context 'when no measures meet their threshold' do
|
||||||
it 'shows a modal on all pages' do
|
it 'shows a modal on dashboard page' do
|
||||||
[dashboard_path, browse_path].each do |path|
|
visit dashboard_path
|
||||||
visit path
|
expect(page).to have_css '.modal'
|
||||||
expect(page).to have_css '.modal'
|
end
|
||||||
end
|
|
||||||
|
it 'does not show a modal on the browse page' do
|
||||||
|
visit browse_path
|
||||||
|
expect(page).not_to have_css '.modal'
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue