Refactor code based on rubocop and reek suggestions

app/controllers/analyze_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AnalyzeController < SqmApplicationController
   def index
     assign_categories
@@ -19,7 +21,7 @@ class AnalyzeController < SqmApplicationController
   end
 
   def assign_measures
-    @measures = @subcategory.measures.order(:measure_id).includes(%i[scales admin_data_items subcategory])
+    @measures = @subcategory.measures.order(:measure_id).includes(%i[subcategory])
   end
 
   def assign_academic_years

app/controllers/application_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
   before_action :set_google_analytics_id
   before_action :set_hotjar_id

app/controllers/categories_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CategoriesController < SqmApplicationController
   helper GaugeHelper
   def show

app/controllers/home_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class HomeController < ApplicationController
   helper HeaderHelper
   def index

app/controllers/overview_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class OverviewController < SqmApplicationController
   before_action :check_empty_dataset, only: [:index]
   helper VarianceHelper
@@ -16,7 +18,7 @@ class OverviewController < SqmApplicationController
   end
 
   def check_empty_dataset
-    @has_empty_dataset = !subcategories.any? do |subcategory|
+    @has_empty_dataset = subcategories.none? do |subcategory|
       response_rate = subcategory.response_rate(school: @school, academic_year: @academic_year)
       response_rate.meets_student_threshold || response_rate.meets_teacher_threshold
     end

app/controllers/sqm_application_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SqmApplicationController < ApplicationController
   protect_from_forgery with: :exception, prepend: true
   before_action :set_schools_and_districts