gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-07 21:48:16 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

rename SurveyItemResponse method for clarity

Browse source
This commit is contained in:
Gabe Farrell 2024-04-10 14:39:19 -04:00
parent a085afb3b6
commit b08214fe10
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/models/report/survey_item.rb
View file

@ -8,7 +8,7 @@ module Report
# Convert they keys in this hash to a hash where the key is the grade
# and the value is a set of sufficient survey IDs
survey_ids_to_grades = Hash.new
SurveyItemResponse.student_survey_items_with_sufficient_responses_by_grade(
SurveyItemResponse.student_survey_items_with_responses_by_grade(
school:,
academic_year:
).each do |key, count|

2
app/models/student_response_rate_calculator.rb
View file

@ -43,7 +43,7 @@ class StudentResponseRateCalculator < ResponseRateCalculator
quarter_of_grade = enrollment_by_grade[grade] / 4
threshold = threshold > quarter_of_grade ? quarter_of_grade : threshold
si = SurveyItemResponse.student_survey_items_with_sufficient_responses_by_grade(school:,
si = SurveyItemResponse.student_survey_items_with_responses_by_grade(school:,
academic_year:)
si = si.reject do |_key, value|
value < threshold

6
app/models/survey_item_response.rb
View file

@ -70,8 +70,8 @@ class SurveyItemResponse < ActiveRecord::Base
@teacher_survey_items_with_sufficient_responses[[school, academic_year]]
end
def self.student_survey_items_with_sufficient_responses_by_grade(school:, academic_year:)
@student_survey_items_with_sufficient_responses_by_grade ||= Hash.new do |memo, (school, academic_year)|
def self.student_survey_items_with_responses_by_grade(school:, academic_year:)
@student_survey_items_with_responses_by_grade ||= Hash.new do |memo, (school, academic_year)|
hash = SurveyItem.joins("inner join survey_item_responses on survey_item_responses.survey_item_id = survey_items.id")
.student_survey_items
.where("survey_item_responses.school": school, "survey_item_responses.academic_year": academic_year)
@ -80,6 +80,6 @@ class SurveyItemResponse < ActiveRecord::Base
memo[[school, academic_year]] = hash
end
@student_survey_items_with_sufficient_responses_by_grade[[school, academic_year]]
@student_survey_items_with_responses_by_grade[[school, academic_year]]
end
end