Add benchmarks to survey and admin data items. Remove them from measures. Modify seeder

Calculate benchmarks for measures based on a weighted average of survey
and admin data items

Added architectural records

spec/controllers/legacy/questions_controller_spec.rb

@@ -20,13 +20,12 @@ require 'rails_helper'
 
 module Legacy
   RSpec.describe QuestionsController, type: :controller do
-
     # This should return the minimal set of attributes required to create a valid
     # Question. As you add validations to Question, be sure to
     # adjust the attributes here as well.
     let!(:user) { User.create(email: 'test@test.com', password: '123456') }
-    let (:category) { Legacy::Category.create!(name: 'Category') }
-    let(:valid_attributes) {
+    let(:category) { Legacy::Category.create!(name: 'Category') }
+    let(:valid_attributes) do
       {
         text: 'Question',
         option1: 'option1',
@@ -36,11 +35,11 @@ module Legacy
         option5: 'option5',
         category_id: category.id
       }
-    }
+    end
 
-    let(:invalid_attributes) {
+    let(:invalid_attributes) do
       { text: '' }
-    }
+    end
 
     # This should return the minimal set of values that should be in the session
     # in order to pass any filters (e.g. authentication) defined in
@@ -51,16 +50,16 @@ module Legacy
       sign_in user
     end
 
-    describe "GET #index" do
-      it "assigns all questions as @questions" do
+    describe 'GET #index' do
+      it 'assigns all questions as @questions' do
         question = Question.create! valid_attributes
         get :index, params: {}, session: valid_session
         expect(assigns(:questions)).to eq([question])
       end
     end
 
-    describe "GET #show" do
-      it "assigns the requested question as @question" do
+    describe 'GET #show' do
+      it 'assigns the requested question as @question' do
         school = School.create!(name: 'School')
         question = Question.create! valid_attributes
         get :show, params: { school_id: school.id, id: question.to_param }, session: valid_session
@@ -69,82 +68,82 @@ module Legacy
       end
     end
 
-    describe "GET #new" do
-      it "assigns a new question as @question" do
+    describe 'GET #new' do
+      it 'assigns a new question as @question' do
         get :new, params: {}, session: valid_session
         expect(assigns(:question)).to be_a_new(Question)
       end
     end
 
-    describe "GET #edit" do
-      it "assigns the requested question as @question" do
+    describe 'GET #edit' do
+      it 'assigns the requested question as @question' do
         question = Question.create! valid_attributes
         get :edit, params: { id: question.to_param }, session: valid_session
         expect(assigns(:question)).to eq(question)
       end
     end
 
-    describe "POST #create" do
-      context "with valid params" do
-        it "creates a new Question" do
-          expect {
+    describe 'POST #create' do
+      context 'with valid params' do
+        it 'creates a new Question' do
+          expect do
             post :create, params: { question: valid_attributes }, session: valid_session
-          }.to change(Question, :count).by(1)
+          end.to change(Question, :count).by(1)
         end
 
-        it "assigns a newly created question as @question" do
+        it 'assigns a newly created question as @question' do
           post :create, params: { question: valid_attributes }, session: valid_session
           expect(assigns(:question)).to be_a(Question)
           expect(assigns(:question)).to be_persisted
         end
 
-        it "redirects to the created question" do
+        it 'redirects to the created question' do
           post :create, params: { question: valid_attributes }, session: valid_session
           expect(response).to redirect_to(Question.last)
         end
       end
 
-      context "with invalid params" do
-        it "assigns a newly created but unsaved question as @question" do
+      context 'with invalid params' do
+        it 'assigns a newly created but unsaved question as @question' do
           post :create, params: { question: invalid_attributes }, session: valid_session
           expect(assigns(:question)).to be_a_new(Question)
         end
 
         it "re-renders the 'new' template" do
           post :create, params: { question: invalid_attributes }, session: valid_session
-          expect(response).to render_template("new")
+          expect(response).to render_template('new')
         end
       end
     end
 
-    describe "PUT #update" do
-      context "with valid params" do
-        let(:new_attributes) {
+    describe 'PUT #update' do
+      context 'with valid params' do
+        let(:new_attributes) do
           { text: 'Question2' }
-        }
+        end
 
-        it "updates the requested question" do
+        it 'updates the requested question' do
           question = Question.create! valid_attributes
           put :update, params: { id: question.to_param, question: new_attributes }, session: valid_session
           question.reload
           expect(question.text).to eq('Question2')
         end
 
-        it "assigns the requested question as @question" do
+        it 'assigns the requested question as @question' do
           question = Question.create! valid_attributes
           put :update, params: { id: question.to_param, question: valid_attributes }, session: valid_session
           expect(assigns(:question)).to eq(question)
         end
 
-        it "redirects to the question" do
+        it 'redirects to the question' do
           question = Question.create! valid_attributes
           put :update, params: { id: question.to_param, question: valid_attributes }, session: valid_session
           expect(response).to redirect_to(question)
         end
       end
 
-      context "with invalid params" do
-        it "assigns the question as @question" do
+      context 'with invalid params' do
+        it 'assigns the question as @question' do
           question = Question.create! valid_attributes
           put :update, params: { id: question.to_param, question: invalid_attributes }, session: valid_session
           expect(assigns(:question)).to eq(question)
@@ -153,25 +152,24 @@ module Legacy
         it "re-renders the 'edit' template" do
           question = Question.create! valid_attributes
           put :update, params: { id: question.to_param, question: invalid_attributes }, session: valid_session
-          expect(response).to render_template("edit")
+          expect(response).to render_template('edit')
         end
       end
     end
 
-    describe "DELETE #destroy" do
-      it "destroys the requested question" do
+    describe 'DELETE #destroy' do
+      it 'destroys the requested question' do
         question = Question.create! valid_attributes
-        expect {
+        expect do
           delete :destroy, params: { id: question.to_param }, session: valid_session
-        }.to change(Question, :count).by(-1)
+        end.to change(Question, :count).by(-1)
       end
 
-      it "redirects to the questions list" do
+      it 'redirects to the questions list' do
         question = Question.create! valid_attributes
         delete :destroy, params: { id: question.to_param }, session: valid_session
         expect(response).to redirect_to(legacy_questions_url)
       end
     end
-
   end
 end