gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-07 21:48:16 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unused method; item_descriptions

Browse source
This commit is contained in:
rebuilt 2023-02-13 17:49:38 -08:00
parent 6b4cfabb5a
commit a72fd373dc
3 changed files with 5 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

24
spec/presenters/data_item_presenters/teacher_survey_presenter_spec.rb
View file

@ -32,28 +32,6 @@ describe TeacherSurveyPresenter do
survey_item_4
end
describe '#item_description' do
context 'When the presenter is based on measure 1A-1' do
it 'returns a list of survey prompts for teacher survey items' do
expect(TeacherSurveyPresenter.new(measure_id: measure_1A_i.measure_id, survey_items: measure_1A_i.teacher_survey_items,
has_sufficient_data: true, school:, academic_year:).item_descriptions).to eq [
'Given your preparation for teaching how comfortable are you teaching at the grade-level you have been assigned?',
'How prepared are you for teaching the topics that you are expected to teach in your assignment?',
'How confident are you in working with the student body at your school?'
]
end
end
context 'When the presenter is based on measure 1B-i' do
it 'returns a message hiding the actual prompts. Instead it presents a message telling the user they can ask for more information' do
expect(TeacherSurveyPresenter.new(measure_id: measure_1B_i.measure_id, survey_items: measure_1B_i.teacher_survey_items,
has_sufficient_data: true, school:, academic_year:).item_descriptions).to eq [
'Items available upon request to MCIEA.'
]
end
end
end
describe '#descriptions_and_availability' do
context 'When the presenter is NOT based on measure 1B-i' do
it 'returns a list containing the survey item properties' do
@ -86,7 +64,7 @@ describe TeacherSurveyPresenter do
academic_year:
).descriptions_and_availability
).to eq [
DataAvailability.new('1B-i', 'Items available upon request to MCIEA.', true)
DataAvailability.new('1B-i', 'Items available upon request to Lowell Public Schools.', true)
]
end
end

6
spec/presenters/measure_presenter_spec.rb
View file

@ -41,8 +41,6 @@ describe MeasurePresenter do
expect(measure_presenter.data_item_presenters.first.id).to eq 'teacher-survey-items-measure-id'
expect(measure_presenter.data_item_presenters.first.title).to eq 'Teacher survey'
expect(measure_presenter.data_item_presenters.first.data_item_accordion_id).to eq 'data-item-accordion-measure-id'
expect(measure_presenter.data_item_presenters.first.item_descriptions).to eq ['A teacher survey item prompt',
'Another teacher survey item prompt']
end
end
@ -61,15 +59,11 @@ describe MeasurePresenter do
expect(first_data_item_presenter.id).to eq 'teacher-survey-items-measure-id'
expect(first_data_item_presenter.title).to eq 'Teacher survey'
expect(first_data_item_presenter.data_item_accordion_id).to eq 'data-item-accordion-measure-id'
expect(first_data_item_presenter.item_descriptions).to eq ['A teacher survey item prompt',
'Another teacher survey item prompt']
second_data_item_presenter = measure_presenter.data_item_presenters[1]
expect(second_data_item_presenter.id).to eq 'admin-data-items-measure-id'
expect(second_data_item_presenter.title).to eq 'School admin data'
expect(second_data_item_presenter.data_item_accordion_id).to eq 'data-item-accordion-measure-id'
expect(second_data_item_presenter.item_descriptions).to eq ['An admin data item description',
'Another admin data item description']
end
end