gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-07 21:48:16 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Makes sure that subcategory displays all measures

Browse source
This commit is contained in:
rebuilt 2021-11-01 21:58:18 +01:00
parent 228cf137ad
commit 7461377066
2 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/presenters/subcategory_presenter.rb
View file

@ -27,7 +27,7 @@ class SubcategoryPresenter
end
def measure_presenters
measures.map { |measure| MeasurePresenter.new(measure: measure, academic_year: @academic_year, school: @school) }
@subcategory.measures.map { |measure| MeasurePresenter.new(measure: measure, academic_year: @academic_year, school: @school) }
end
private

7
spec/presenters/subcategory_presenter_spec.rb
View file

@ -3,9 +3,8 @@ require 'rails_helper'
describe SubcategoryPresenter do
let(:academic_year) { create(:academic_year, range: '1989-90') }
let(:school) { create(:school, name: 'Best School') }
let(:subcategory) { create(:subcategory, name: 'A great subcategory', description: 'A great description') }
let(:subcategory_presenter) do
subcategory = create(:subcategory, name: 'A great subcategory', description: 'A great description')
measure1 = create(:measure, watch_low_benchmark: 4, growth_low_benchmark: 4.25, approval_low_benchmark: 4.5, ideal_low_benchmark: 4.75, subcategory: subcategory)
survey_item1 = create(:survey_item, measure: measure1)
create(:survey_item_response, survey_item: survey_item1, academic_year: academic_year, school: school, likert_score: 1)
@ -36,6 +35,10 @@ describe SubcategoryPresenter do
expect(subcategory_presenter.gauge_presenter.title).to eq 'Growth'
end
it 'creates a measure presenter for each measure in a subcategory' do
expect(subcategory_presenter.measure_presenters.count).to eq subcategory.measures.count
end
context 'When there are no measures populated with student or teacher surveys' do
let(:empty_subcategory) { create :subcategory }
let(:empty_subcategory_presenter) { SubcategoryPresenter.new(subcategory: empty_subcategory, academic_year: academic_year, school: school )}