Refactor response rate

This commit is contained in:
rebuilt 2022-02-02 11:04:30 +01:00
parent 0c5fbea203
commit 67d51aff5e
5 changed files with 75 additions and 74 deletions

View file

@ -5,71 +5,13 @@ class ResponseRate
@academic_year = academic_year
end
def student
rate(survey_item_count: student_survey_item_count, response_count: student_response_count,
total_possible_responses: total_possible_student_responses)
end
def teacher
response_rate = rate(survey_item_count: teacher_survey_item_count, response_count: teacher_response_count,
total_possible_responses: total_possible_teacher_responses)
cap_at_100(response_rate)
end
private
def cap_at_100(response_rate)
response_rate > 100 ? 100 : response_rate
end
def rate(survey_item_count:, response_count:, total_possible_responses:)
def rate
return 0 unless survey_item_count.positive?
average_responses_per_survey_item = response_count / survey_item_count
average_responses_per_survey_item = response_count / survey_item_count.to_f
return 0 unless total_possible_responses.positive?
(average_responses_per_survey_item / total_possible_responses * 100).round
end
def total_possible_student_responses
@total_possible_student_responses ||= total_possible_responses do |responses|
responses.total_students
end
end
def total_possible_teacher_responses
@total_possible_teacher_responses ||= total_possible_responses do |responses|
responses.total_teachers
end
end
def total_possible_responses
total_responses = Respondent.where(school: @school, academic_year: @academic_year).first
return 0 unless total_responses.present?
yield total_responses
end
def student_response_count
@student_response_count ||= SurveyItemResponse.student_responses_for_measures(@subcategory.measures, @school,
@academic_year).count.to_f
end
def teacher_response_count
@teacher_response_count ||= SurveyItemResponse.teacher_responses_for_measures(@subcategory.measures, @school,
@academic_year).count.to_f
end
def student_survey_item_count
@student_survey_item_count ||= @subcategory.measures.map do |measure|
measure.student_survey_items.count
end.sum.to_f
end
def teacher_survey_item_count
@teacher_survey_item_count ||= @subcategory.measures.map do |measure|
measure.teacher_survey_items.count
end.sum.to_f
(average_responses_per_survey_item / total_possible_responses.to_f * 100).round
end
end

View file

@ -0,0 +1,27 @@
class StudentResponseRate < ResponseRate
def rate
super
end
private
def survey_item_count
@student_survey_item_count ||= @subcategory.measures.map do |measure|
measure.student_survey_items.count
end.sum
end
def response_count
@student_response_count ||= SurveyItemResponse.student_responses_for_measures(@subcategory.measures, @school,
@academic_year).count
end
def total_possible_responses
@total_possible_student_responses ||= begin
total_responses = Respondent.where(school: @school, academic_year: @academic_year).first
return 0 unless total_responses.present?
total_responses.total_students
end
end
end

View file

@ -0,0 +1,31 @@
class TeacherResponseRate < ResponseRate
def rate
cap_at_100(super)
end
private
def cap_at_100(response_rate)
response_rate > 100 ? 100 : response_rate
end
def survey_item_count
@teacher_survey_item_count ||= @subcategory.measures.map do |measure|
measure.teacher_survey_items.count
end.sum
end
def response_count
@teacher_response_count ||= SurveyItemResponse.teacher_responses_for_measures(@subcategory.measures, @school,
@academic_year).count
end
def total_possible_responses
@total_possible_teacher_responses ||= begin
total_responses = Respondent.where(school: @school, academic_year: @academic_year).first
return 0 unless total_responses.present?
total_responses.total_teachers
end
end
end