gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-07 21:48:16 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use less memory when loading race scores

Browse source
This commit is contained in:
rebuilt 2022-08-12 02:56:25 -07:00
parent 54ea1a1070
commit 58f5b01471
3 changed files with 34 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

9
app/services/race_score_loader.rb
View file

@ -1,27 +1,24 @@
class RaceScoreLoader class RaceScoreLoader
def self.reset(schools: School.all, academic_years: AcademicYear.all, measures: Measure.all, races: Race.all) def self.reset(schools: School.all, academic_years: AcademicYear.all, measures: Measure.all, races: Race.all)
RaceScore.where(school: schools, academic_year: academic_years, measure: measures, race: races).delete_all
scores = []
measures.each do |measure| measures.each do |measure|
schools.each do |school| schools.each do |school|
academic_years.each do |academic_year| academic_years.each do |academic_year|
races.each do |race| races.each do |race|
scores << process_score(measure:, school:, academic_year:, race:) process_score(measure:, school:, academic_year:, race:)
end end
end end
end end
end end
RaceScore.import scores, batch_size: 1000
end end
private private
def self.process_score(measure:, school:, academic_year:, race:) def self.process_score(measure:, school:, academic_year:, race:)
score = RaceScoreCalculator.new(measure:, school:, academic_year:, race:).score score = RaceScoreCalculator.new(measure:, school:, academic_year:, race:).score
rs = RaceScore.new(measure:, school:, academic_year:, race:) rs = RaceScore.find_or_create_by(measure:, school:, academic_year:, race:)
rs.average = score.average rs.average = score.average
rs.meets_student_threshold = score.meets_student_threshold? rs.meets_student_threshold = score.meets_student_threshold?
rs rs.save
end end
private_class_method :process_score private_class_method :process_score

31
spec/models/race_score_calulator_spec.rb
View file

@ -5,11 +5,15 @@ describe RaceScoreCalculator do
let(:school) { create(:school) } let(:school) { create(:school) }
let(:academic_year) { create(:academic_year) } let(:academic_year) { create(:academic_year) }
let(:race) { create(:race) } let(:race) { create(:race) }
let(:student) do let(:students) do
s = create(:student) [].tap do |arr|
s.races << race 10.times do
s.save s = create(:student)
s s.races << race
s.save
arr << s
end
end
end end
let(:survey_item_1) { measure.survey_items[0] } let(:survey_item_1) { measure.survey_items[0] }
let(:survey_item_2) { measure.survey_items[1] } let(:survey_item_2) { measure.survey_items[1] }
@ -18,18 +22,15 @@ describe RaceScoreCalculator do
create(:response_rate, school:, academic_year:, subcategory: measure.subcategory, meets_student_threshold: true) create(:response_rate, school:, academic_year:, subcategory: measure.subcategory, meets_student_threshold: true)
end end
xcontext 'when survey item responses exist' do context 'when survey item responses exist' do
before :each do before :each do
response_rate response_rate
create(:survey_item_response, school:, academic_year:, likert_score: 1, survey_item: survey_item_1, student:) students.each do |student|
create_list(:survey_item_response, 8, school:, academic_year:, likert_score: 2, survey_item: survey_item_1, create(:survey_item_response, school:, academic_year:, likert_score: 2, survey_item: survey_item_1, student:)
student:) end
create(:survey_item_response, school:, academic_year:, likert_score: 3, survey_item: survey_item_1, student:) students.each do |student|
create(:survey_item_response, school:, academic_year:, likert_score: 3, survey_item: survey_item_2, student:)
create(:survey_item_response, school:, academic_year:, likert_score: 2, survey_item: survey_item_2, student:) end
create_list(:survey_item_response, 8, school:, academic_year:, likert_score: 3, survey_item: survey_item_2,
student:)
create(:survey_item_response, school:, academic_year:, likert_score: 4, survey_item: survey_item_2, student:)
end end
it 'returns a list of averages' do it 'returns a list of averages' do

29
spec/services/race_score_loader_spec.rb
View file

@ -5,11 +5,15 @@ describe RaceScoreLoader do
let(:school) { create(:school) } let(:school) { create(:school) }
let(:academic_year) { create(:academic_year) } let(:academic_year) { create(:academic_year) }
let(:race) { create(:race) } let(:race) { create(:race) }
let(:student) do let(:students) do
s = create(:student) [].tap do |arr|
s.races << race 10.times do
s.save s = create(:student)
s s.races << race
s.save
arr << s
end
end
end end
let(:survey_item_1) { measure.survey_items[0] } let(:survey_item_1) { measure.survey_items[0] }
let(:survey_item_2) { measure.survey_items[1] } let(:survey_item_2) { measure.survey_items[1] }
@ -22,18 +26,15 @@ describe RaceScoreLoader do
context 'when survey item responses exist' do context 'when survey item responses exist' do
before :each do before :each do
response_rate response_rate
create(:survey_item_response, school:, academic_year:, likert_score: 1, survey_item: survey_item_1, student:) students.each do |student|
create_list(:survey_item_response, 8, school:, academic_year:, likert_score: 2, survey_item: survey_item_1, create(:survey_item_response, school:, academic_year:, likert_score: 2, survey_item: survey_item_1, student:)
student:) end
create(:survey_item_response, school:, academic_year:, likert_score: 3, survey_item: survey_item_1, student:) students.each do |student|
create(:survey_item_response, school:, academic_year:, likert_score: 3, survey_item: survey_item_2, student:)
end
create(:survey_item_response, school:, academic_year:, likert_score: 2, survey_item: survey_item_2, student:)
create_list(:survey_item_response, 8, school:, academic_year:, likert_score: 3, survey_item: survey_item_2,
student:)
create(:survey_item_response, school:, academic_year:, likert_score: 4, survey_item: survey_item_2, student:)
RaceScoreLoader.reset RaceScoreLoader.reset
end end
xit 'returns a list of averages' do xit 'returns a list of averages' do
expect(measure.student_survey_items.count).to eq 2 expect(measure.student_survey_items.count).to eq 2
american_indian_score = RaceScore.find_by(measure:, school:, academic_year:, race:) american_indian_score = RaceScore.find_by(measure:, school:, academic_year:, race:)