gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-08 23:18:18 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf: reduce number of queries for teacher survey_items

Browse source
This commit is contained in:
Nelson Jovel 2023-12-26 17:32:39 -08:00
parent 3718d74e62
commit 45ea735fa5
2 changed files with 22 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
app/models/survey_item_response.rb
View file

@ -57,4 +57,16 @@ class SurveyItemResponse < ActiveRecord::Base
end
@grouped_responses[[school, academic_year]]
end
def self.teacher_survey_items_with_sufficient_responses(school:, academic_year:)
@teacher_survey_items_with_sufficient_responses ||= Hash.new do |memo, (school, academic_year)|
hash = SurveyItem.joins("inner join survey_item_responses on survey_item_responses.survey_item_id = survey_items.id")
.teacher_survey_items
.where("survey_item_responses.school": school, "survey_item_responses.academic_year": academic_year)
.group("survey_items.id")
.having("count(*) > 0").count
memo[[school, academic_year]] = hash
end
@teacher_survey_items_with_sufficient_responses[[school, academic_year]]
end
end

16
app/models/teacher_response_rate_calculator.rb
View file

@ -10,15 +10,19 @@ class TeacherResponseRateCalculator < ResponseRateCalculator
end
def survey_items_with_sufficient_responses
SurveyItem.joins("inner join survey_item_responses on survey_item_responses.survey_item_id = survey_items.id")
.teacher_survey_items
.where("survey_item_responses.school": school, "survey_item_responses.academic_year": academic_year, "survey_item_responses.survey_item_id": @subcategory.survey_items.teacher_survey_items)
.group("survey_items.id")
.having("count(*) >= 0").count
@survey_items_with_sufficient_responses ||= {}.tap do |hash|
@subcategory.survey_items.teacher_survey_items.map do |survey_item|
si = SurveyItemResponse.teacher_survey_items_with_sufficient_responses(school:, academic_year:)
count = si[survey_item.id]
next unless count
hash[survey_item.id] = count
end
end
end
def response_count
@response_count ||= survey_items_with_sufficient_responses.values.sum
@response_count ||= survey_items_with_sufficient_responses&.values&.sum
end
def total_possible_responses