gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-07 21:48:16 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: refactor analyze page

Browse source
This commit is contained in:
Nelson Jovel 2024-06-12 10:35:03 -07:00
parent ccb04511bf
commit 3b3bb52523
15 changed files with 99 additions and 96 deletions
Download patch file Download diff file Expand all files Collapse all files

18
spec/presenters/grouped_bar_column_presenter_spec.rb
View file

@ -73,8 +73,8 @@ describe GroupedBarColumnPresenter do
end
let(:all_data_presenter) do
GroupedBarColumnPresenter.new measure: measure_composed_of_student_and_teacher_items, school:, academic_years:,
position: 0, number_of_columns: 3
Analyze::Graph::Column::AllData.new measure: measure_composed_of_student_and_teacher_items, school:, academic_years:,
position: 0, number_of_columns: 3
end
before do
@ -120,8 +120,8 @@ describe GroupedBarColumnPresenter do
end
it "returns a score that is an average of the likert scores " do
expect(all_data_presenter.score(0).average).to eq 4.5
expect(all_data_presenter.score(1).average).to eq nil
expect(all_data_presenter.score(academic_year).average).to eq 4.5
expect(all_data_presenter.score(another_academic_year).average).to eq nil
expect(all_data_presenter.academic_years[0].range).to be academic_year.range
expect(all_data_presenter.academic_years[1].range).to be another_academic_year.range
end
@ -133,8 +133,8 @@ describe GroupedBarColumnPresenter do
academic_year: another_academic_year, likert_score: 3)
end
it "returns independent scores for each year of data" do
expect(all_data_presenter.score(0).average).to eq 4.5
expect(all_data_presenter.score(1).average).to eq 4
expect(all_data_presenter.score(academic_year).average).to eq 4.5
expect(all_data_presenter.score(another_academic_year).average).to eq 4
end
end
end
@ -144,12 +144,8 @@ describe GroupedBarColumnPresenter do
it_behaves_like "measure_name"
it_behaves_like "column_midpoint"
it "returns an emtpy set of bars" do
expect(student_presenter.bars).to eq []
end
it "returns an emty score" do
expect(student_presenter.score(year_index).average).to eq nil
expect(student_presenter.score(academic_year).average).to eq nil
end
it "shows the irrelevancy message " do