gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-07 21:48:16 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unused TODOs

Browse source
This commit is contained in:
rebuilt 2023-04-27 15:47:45 -07:00
parent c5373b5e99
commit 359e266a6c
3 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
app/models/survey_item.rb
View file

@ -31,8 +31,8 @@ class SurveyItem < ActiveRecord::Base
scope :survey_items_for_grade, lambda { |school, academic_year, grade| scope :survey_items_for_grade, lambda { |school, academic_year, grade|
includes(:survey_item_responses) includes(:survey_item_responses)
.where("survey_item_responses.grade": grade, .where("survey_item_responses.grade": grade,
"survey_item_responses.school": school, "survey_item_responses.school": school,
"survey_item_responses.academic_year": academic_year).distinct "survey_item_responses.academic_year": academic_year).distinct
} }
scope :survey_item_ids_for_grade, lambda { |school, academic_year, grade| scope :survey_item_ids_for_grade, lambda { |school, academic_year, grade|
@ -58,7 +58,6 @@ class SurveyItem < ActiveRecord::Base
:regular :regular
} }
# TODO: rename this to Summary
def description def description
Summary.new(survey_item_id, prompt, true) Summary.new(survey_item_id, prompt, true)
end end

1
app/services/dese/four_d_one.rb
View file

@ -1,6 +1,5 @@
require 'watir' require 'watir'
# TODO: convert this to simpler format and add a run_all method
module Dese module Dese
class FourDOne class FourDOne
attr_reader :filepath attr_reader :filepath

1
app/services/dese/one_a_one.rb
View file

@ -1,5 +1,4 @@
require 'watir' require 'watir'
# TODO: use blocks to pass a block of code like other DESE scrapers
module Dese module Dese
class OneAOne class OneAOne