gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-07 21:48:16 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Chore: Reduce queries

Browse source
This commit is contained in:
Gabe Farrell 2024-05-10 14:00:31 -04:00
parent e60a30911c
commit 2f1cf8b9fd
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/models/measure.rb
View file

@ -45,15 +45,15 @@ class Measure < ActiveRecord::Base
end
def includes_teacher_survey_items?
@includes_teacher_survey_items ||= teacher_survey_items.any?
@includes_teacher_survey_items ||= teacher_survey_items.length.positive?
end
def includes_student_survey_items?
@includes_student_survey_items ||= student_survey_items.any?
@includes_student_survey_items ||= student_survey_items.length.positive?
end
def includes_admin_data_items?
@includes_admin_data_items ||= admin_data_items.any?
@includes_admin_data_items ||= admin_data_items.length.positive?
end
def score(school:, academic_year:)

2
app/presenters/category_presenter.rb
View file

@ -36,7 +36,7 @@ class CategoryPresenter
end
def subcategories(academic_year:, school:)
@category.subcategories.includes([:measures]).sort_by(&:subcategory_id).map do |subcategory|
@category.subcategories.sort_by(&:subcategory_id).map do |subcategory|
SubcategoryPresenter.new(
subcategory:,
academic_year:,