gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-07 21:48:16 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix bug that happens when you view gender scores for multiple years

Browse source
This commit is contained in:
rebuilt 2022-11-30 09:14:04 -08:00
parent 43bc55ed32
commit 1f7fa8146c
1 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
app/presenters/analyze/graph/column/gender/score_for_gender.rb
View file

@ -5,7 +5,8 @@ module Analyze
module ScoreForGender
def score(year_index)
academic_year = academic_years[year_index]
averages = SurveyItemResponse.averages_for_gender(measure.student_survey_items, school, academic_year, gender)
averages = SurveyItemResponse.averages_for_gender(measure.student_survey_items, school, academic_year,
gender)
average = bubble_up_averages(averages:)
scorify(average:, meets_student_threshold: sufficient_student_responses?(academic_year:))
@ -23,14 +24,17 @@ module Analyze
return Score::NIL_SCORE unless meets_student_threshold
Score.new(average:,
meets_teacher_threshold: false,
meets_student_threshold: true,
meets_admin_data_threshold: false)
meets_teacher_threshold: false,
meets_student_threshold: true,
meets_admin_data_threshold: false)
end
def sufficient_student_responses?(academic_year:)
yearly_counts = SurveyItemResponse.where(school: , academic_year: , gender:).group(:gender).select(:response_id).distinct(:response_id).count
yearly_counts.first[1] >= 10
yearly_counts = SurveyItemResponse.where(school:, academic_year:,
gender:).group(:gender).select(:response_id).distinct(:response_id).count
yearly_counts.any? do |count|
count[1] >= 10
end
end
end
end