gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-07 13:38:18 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: remove errant zeros from 'survey item by item' report

Browse source
This commit is contained in:
Nelson Jovel 2025-01-16 15:59:56 -08:00
parent 0565df9ed4
commit 1be11d1378
1 changed files with 16 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

25
app/models/report/survey_item_by_item.rb
View file

@ -94,10 +94,12 @@ module Report
if school_grades.include?(grade)
# we already know grade has sufficient responses
row.append("#{survey_item.survey_item_responses.where(school:, academic_year:,
grade:).average(:likert_score).to_f.round(2)}")
score = survey_item.survey_item_responses.where(school:, academic_year:,
grade:).average(:likert_score).to_f.round(2)
score = "" if score.zero?
row.append("#{score}")
else
row.append("N/A")
row.append("")
end
end
@ -110,13 +112,16 @@ module Report
# filter out response rate at subcategory level <24.5% for school average
if response_rate(subcategory: survey_item.subcategory, school:,
academic_year:).meets_student_threshold?
row.append("#{survey_item.survey_item_responses.where(
all_student_score = survey_item.survey_item_responses.where(
# We allow the nil (unknown) grades in the school survey item average
# also filter less than 10 responses in the whole school
'school_id = ? and academic_year_id = ? and (grade IS NULL or grade IN (?))', school.id, academic_year.id, school.grades(academic_year:)
).group('survey_item_id').having('count(*) >= 10').average(:likert_score).values[0].to_f.round(2)}")
"school_id = ? and academic_year_id = ? and (grade IS NULL or grade IN (?))", school.id, academic_year.id, school.grades(academic_year:)
).group("survey_item_id").having("count(*) >= 10").average(:likert_score).values[0].to_f.round(2)
all_student_score = "" if all_student_score.zero?
row.append("#{all_student_score}")
else
row.append("N/A")
row.append("")
end
data << row
end
@ -136,8 +141,10 @@ module Report
padding = Array.new(grades.length + 1) { "" }
row.concat(padding)
# we already know that the survey item we are looking at has sufficient responses
row.append("#{survey_item.survey_item_responses.where(school:,
academic_year:).average(:likert_score).to_f.round(2)}")
all_teacher_score = survey_item.survey_item_responses.where(school:,
academic_year:).average(:likert_score).to_f.round(2)
all_teacher_score = "" if all_teacher_score.zero?
row.append("#{all_teacher_score}")
data << row
end
end