gabehf/sqm-dashboards
1
0
Fork 0
mirror of https://github.com/edcommonwealth/sqm-dashboards.git synced 2026-03-10 07:50:33 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: upgrade to rails 7.1.

Browse source 
upgrade rspec

fix failing tests

upgrade devise
This commit is contained in:
rebuilt 2023-10-06 14:41:16 -07:00
parent 2fd56047d4
commit 18ab51c860
12 changed files with 268 additions and 238 deletions
Download patch file Download diff file Expand all files Collapse all files

16
spec/services/enrollment_loader_spec.rb
View file

@ -1,12 +1,12 @@
require 'rails_helper'
require "rails_helper"
describe EnrollmentLoader do
let(:path_to_enrollment_data) { Rails.root.join('spec', 'fixtures', 'sample_enrollment_data.csv') }
let(:ay_2022_23) { create(:academic_year, range: '2022-23') }
let(:path_to_enrollment_data) { Rails.root.join("spec", "fixtures", "sample_enrollment_data.csv") }
let(:ay_2022_23) { create(:academic_year, range: "2022-23") }
let(:attleboro) { School.find_or_create_by(name: 'Attleboro', dese_id: 160_505) }
let(:beachmont) { School.find_or_create_by(name: 'Beachmont', dese_id: 2_480_013) }
let(:winchester) { School.find_or_create_by(name: 'Winchester', dese_id: 3_440_505) }
let(:attleboro) { create(:school, name: "Attleboro", dese_id: 160_505) }
let(:beachmont) { create(:school, name: "Beachmont", dese_id: 2_480_013) }
let(:winchester) { create(:school, name: "Winchester", dese_id: 3_440_505) }
before :each do
ay_2022_23
attleboro
@ -19,8 +19,8 @@ describe EnrollmentLoader do
DatabaseCleaner.clean
end
context 'self.load_data' do
it 'loads the correct enrollment numbers' do
context "self.load_data" do
it "loads the correct enrollment numbers" do
academic_year = ay_2022_23
expect(Respondent.find_by(school: attleboro, academic_year:).nine).to eq 506
# expect(Respondent.find_by(school: attleboro, academic_year:).total_students).to eq 1844

22
spec/services/staffing_loader_spec.rb
View file

@ -1,12 +1,12 @@
require 'rails_helper'
require "rails_helper"
describe StaffingLoader do
let(:path_to_staffing_data) { Rails.root.join('spec', 'fixtures', 'sample_staffing_data.csv') }
let(:ay_2022_23) { create(:academic_year, range: '2022-23') }
let(:ay_2021_22) { create(:academic_year, range: '2021-22') }
let(:attleboro) { School.find_or_create_by(name: 'Attleboro', dese_id: 160_505) }
let(:beachmont) { School.find_or_create_by(name: 'Beachmont', dese_id: 2_480_013) }
let(:winchester) { School.find_or_create_by(name: 'Winchester', dese_id: 3_440_505) }
let(:path_to_staffing_data) { Rails.root.join("spec", "fixtures", "sample_staffing_data.csv") }
let(:ay_2022_23) { create(:academic_year, range: "2022-23") }
let(:ay_2021_22) { create(:academic_year, range: "2021-22") }
let(:attleboro) { create(:school, name: "Attleboro", dese_id: 160_505) }
let(:beachmont) { create(:school, name: "Beachmont", dese_id: 2_480_013) }
let(:winchester) { create(:school, name: "Winchester", dese_id: 3_440_505) }
before :each do
ay_2022_23
@ -22,8 +22,8 @@ describe StaffingLoader do
DatabaseCleaner.clean
end
context 'self.load_data' do
it 'loads the correct staffing numbers' do
context "self.load_data" do
it "loads the correct staffing numbers" do
academic_year = ay_2021_22
expect(Respondent.find_by(school: attleboro, academic_year:).total_teachers).to eq 197.5
@ -32,11 +32,11 @@ describe StaffingLoader do
expect(Respondent.find_by(school: winchester, academic_year:).total_teachers).to eq 149.8
end
context 'when the staffing data is missing a school' do
context "when the staffing data is missing a school" do
after :each do
DatabaseCleaner.clean
end
it 'fills in empty staffing numbers with the previous years data' do
it "fills in empty staffing numbers with the previous years data" do
academic_year = ay_2022_23
expect(Respondent.find_by(school: attleboro, academic_year:).total_teachers).to eq 197.5