gabehf/bimg
1
0
Fork 0
mirror of https://github.com/talgo-cloud/bimg.git synced 2026-03-15 18:35:54 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix: Crop is doing resize. Closes #128

Browse source
This commit is contained in:
Dan Persa 2017-01-13 16:13:51 +01:00
parent e099e4c9f5
commit 9b6989c3ce
2 changed files with 14 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
image_test.go
View file

@ -176,7 +176,7 @@ func TestImageCropByWidth(t *testing.T) {
t.Errorf("Cannot process the image: %s", err) t.Errorf("Cannot process the image: %s", err)
} }
err = assertSize(buf, 600, 375) err = assertSize(buf, 600, 1050)
if err != nil { if err != nil {
t.Error(err) t.Error(err)
} }
@ -190,7 +190,7 @@ func TestImageCropByHeight(t *testing.T) {
t.Errorf("Cannot process the image: %s", err) t.Errorf("Cannot process the image: %s", err)
} }
err = assertSize(buf, 480, 300) err = assertSize(buf, 1680, 300)
if err != nil { if err != nil {
t.Error(err) t.Error(err)
} }

16
resize.go
View file

@ -401,12 +401,20 @@ func imageCalculations(o *Options, inWidth, inHeight int) float64 {
} }
// Fixed width, auto height // Fixed width, auto height
case o.Width > 0: case o.Width > 0:
factor = xfactor if o.Crop {
o.Height = roundFloat(float64(inHeight) / factor) o.Height = inHeight
} else {
factor = xfactor
o.Height = roundFloat(float64(inHeight) / factor)
}
// Fixed height, auto width // Fixed height, auto width
case o.Height > 0: case o.Height > 0:
factor = yfactor if o.Crop {
o.Width = roundFloat(float64(inWidth) / factor) o.Width = inWidth
} else {
factor = yfactor
o.Width = roundFloat(float64(inWidth) / factor)
}
// Identity transform // Identity transform
default: default:
o.Width = inWidth o.Width = inWidth