fix weird theme colors on light terminal bg | https://github.com/NvChad/NvChad/issues/1046

thanks to @tamton-aquib as he informed me about the :h bg option!

lua/base46.lua

@@ -1,9 +1,6 @@
 local M = {}
 
-M.get_colors = function(type)
-   local name = vim.g.nvchad_theme
-
-   -- theme paths
+M.get_theme_tb = function(name, type)
    local default_path = "hl_themes." .. name
    local user_path = "custom.themes." .. name
 
@@ -19,11 +16,20 @@ M.get_colors = function(type)
    end
 end
 
+M.get_colors = function(type)
+   local name = vim.g.nvchad_theme
+   return M.get_theme_tb(name, type)
+end
+
 M.merge_tb = function(table1, table2)
    return vim.tbl_deep_extend("force", table1, table2)
 end
 
 M.load_theme = function()
+   -- set bg option
+   local theme_type = M.get_theme_tb(vim.g.nvchad_theme, "type") -- dark/light
+   vim.opt.bg = theme_type
+
    -- clear highlights of bufferline (cuz of dynamic devicons hl group on the buffer)
    local highlights_raw = vim.split(vim.api.nvim_exec("filter BufferLine hi", true), "\n")
    local highlight_groups = {}

lua/hl_themes/aquarium.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#eAc1c1",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "aquarium")
 
 return M

lua/hl_themes/blossom.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#887c76",
 }
 
+M.type = "light"
+
 M = require("base46").override_theme(M, "blossom")
 
 return M

lua/hl_themes/catppuccin.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#E8A2AF",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "catppuccin")
 
 return M

lua/hl_themes/chadracula.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#f7f7fb",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "chadracula")
 
 return M

lua/hl_themes/chadtain.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#8b6567",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "chadtain")
 
 return M

lua/hl_themes/doomchad.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#c85a50",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "doomchad")
 
 return M

lua/hl_themes/everforest.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#e67e80",
 }
 
+M.type = "dark"
+
 M.polish_hl = {
    TSPunctBracket = {
       fg = M.base_30.red,

lua/hl_themes/everforest_light.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#d699b6",
 }
 
+M.type = "light"
+
 M.polish_hl = {
    DiffAdd = {
       fg = M.base_30.green,

lua/hl_themes/gruvbox.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#d65d0e",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "gruvbox")
 
 return M

lua/hl_themes/gruvchad.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base06 = "#c3b499",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "gruvchad")
 
 return M

lua/hl_themes/jellybeans.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#cf6a4c",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "jellybeans")
 
 return M

lua/hl_themes/kanagawa.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#d27e99",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "kanagawa")
 
 return M

lua/hl_themes/monekai.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#bbc2cf",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "monekai")
 
 return M

lua/hl_themes/mountain.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#9d9a7b",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "mountain")
 
 return M

lua/hl_themes/nightlamp.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#d0d0c7",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "nightlamp")
 
 return M

lua/hl_themes/nightowl.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#d6deeb", -- Deprecated, Opening/Closing Embedded Language Tags, e.g. <?php ?>
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "nightowl")
 
 return M

lua/hl_themes/nord.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#B48EAD",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "nord")
 
 return M

lua/hl_themes/one_light.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#986801",
 }
 
+M.type = "light"
+
 M.polish_hl = {
    WhichKeyDesc = {
       fg = M.base_30.white,

lua/hl_themes/onedark.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#be5046",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "onedark")
 
 return M

lua/hl_themes/onenord.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base06 = "#c7cdd8",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "onenord")
 
 return M

lua/hl_themes/palenight.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#ff5370",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "palenight")
 
 return M

lua/hl_themes/pastelDark.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base06 = "#d3d9e4",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "javacafe")
 
 return M

lua/hl_themes/radium.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#e87979",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "radium")
 
 return M

lua/hl_themes/rxyhn.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#F16269",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "rxyhn")
 
 return M

lua/hl_themes/solarized.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#d33682",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "solarized")
 
 return M

lua/hl_themes/tokyodark.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#f3627a",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "tokyodark")
 
 return M

lua/hl_themes/tokyonight.lua

@@ -53,4 +53,8 @@ M.base_16 = {
    base06 = "#bbc5f0",
 }
 
+M.type = "dark"
+
+M = require("base46").override_theme(M, "tokyonight")
+
 return M

lua/hl_themes/tomorrow_night.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base06 = "#e0e0e0",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "tomorrow_night")
 
 return M

lua/hl_themes/wombat.lua

@@ -53,6 +53,8 @@ M.base_16 = {
    base0F = "#dc8c64",
 }
 
+M.type = "dark"
+
 M = require("base46").override_theme(M, "wombat")
 
 return M