From 2733812d94415a7ca8ff5c3d84b91818d8bd3a93 Mon Sep 17 00:00:00 2001 From: buthed010203 Date: Fri, 14 Oct 2022 12:35:29 -0400 Subject: [PATCH 1/3] Remove problematic default value The tooltip explains that leaving this blank will keep all subs. That isn't the case with a non blank default value. --- Community/Tdarr_Plugin_drdd_standardise_all_in_one.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Community/Tdarr_Plugin_drdd_standardise_all_in_one.js b/Community/Tdarr_Plugin_drdd_standardise_all_in_one.js index ea8dc7c..4c87764 100644 --- a/Community/Tdarr_Plugin_drdd_standardise_all_in_one.js +++ b/Community/Tdarr_Plugin_drdd_standardise_all_in_one.js @@ -46,7 +46,7 @@ const details = () => { { name: "wanted_subtitle_languages", type: 'string', - defaultValue: 'eng,fre', + defaultValue: '', inputUI: { type: 'text', }, From 06c99f617ef6c7558c58f8d16c0f7f944a2ef65e Mon Sep 17 00:00:00 2001 From: HaveAGitGat <43864057+HaveAGitGat@users.noreply.github.com> Date: Wed, 22 Mar 2023 05:30:30 +0000 Subject: [PATCH 3/3] Update tests --- .../Tdarr_Plugin_drdd_standardise_all_in_one.js | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/Community/Tdarr_Plugin_drdd_standardise_all_in_one.js b/tests/Community/Tdarr_Plugin_drdd_standardise_all_in_one.js index 250a2a7..2a46f53 100644 --- a/tests/Community/Tdarr_Plugin_drdd_standardise_all_in_one.js +++ b/tests/Community/Tdarr_Plugin_drdd_standardise_all_in_one.js @@ -20,9 +20,7 @@ const tests = [ + '• Original Bitrate: 1517\n' + '• Target Bitrate: 1517\n' + '• Minimum Bitrate: 1061\n' - + '• Maximum Bitrate: 1972\n' - + '\n' - + '☑ No subtitle processing necessary', + + '• Maximum Bitrate: 1972\n', processFile: true, preset: ',-map 0 -map -0:d -c:v libx265 -b:v 1517k -minrate 1061k -maxrate 1972k -bufsize 1517k -c:a copy -c:a:0 ac3 -c:s copy -max_muxing_queue_size 4096', reQueueAfter: false, @@ -47,9 +45,7 @@ const tests = [ + '• Original Bitrate: 1517\n' + '• Target Bitrate: 1517\n' + '• Minimum Bitrate: 1061\n' - + '• Maximum Bitrate: 1972\n' - + '\n' - + '☑ No subtitle processing necessary', + + '• Maximum Bitrate: 1972\n', processFile: true, preset: '-c:v h264_cuvid,-map 0 -map -0:d -c:v hevc_nvenc -cq:v 19 -b:v 1517k -minrate 1061k -maxrate 1972k -bufsize 1517k -spatial_aq:v 1 -rc-lookahead:v 32 -c:a copy -c:a:0 ac3 -c:s copy -max_muxing_queue_size 4096', reQueueAfter: false, @@ -62,6 +58,7 @@ const tests = [ inputs: { nvenc: 'false', qsv: 'true', + wanted_subtitle_languages: 'eng,fre', }, otherArguments: {}, }, @@ -87,7 +84,9 @@ const tests = [ input: { file: _.cloneDeep(require('../sampleData/media/sampleH265_1.json')), librarySettings: {}, - inputs: {}, + inputs: { + wanted_subtitle_languages: 'eng,fre', + }, otherArguments: {}, }, output: {