From 98bd5a115f6702ba5c1686a83e5d32ee3e7b893b Mon Sep 17 00:00:00 2001
From: HaveAGitGat <43864057+HaveAGitGat@users.noreply.github.com>
Date: Thu, 28 Jan 2021 09:20:44 +0100
Subject: [PATCH] fix loop bug

---
 .../Tdarr_Plugin_MC93_Migz2CleanTitle.js      | 27 +++++++++++++++----
 1 file changed, 22 insertions(+), 5 deletions(-)

diff --git a/Community/Tdarr_Plugin_MC93_Migz2CleanTitle.js b/Community/Tdarr_Plugin_MC93_Migz2CleanTitle.js
index 2992a4b..0e26cc4 100644
--- a/Community/Tdarr_Plugin_MC93_Migz2CleanTitle.js
+++ b/Community/Tdarr_Plugin_MC93_Migz2CleanTitle.js
@@ -1,4 +1,3 @@
-/* eslint no-plusplus: ["error", { "allowForLoopAfterthoughts": true }] */
 function details() {
   return {
     id: 'Tdarr_Plugin_MC93_Migz2CleanTitle',
@@ -89,12 +88,18 @@ function plugin(file, librarySettings, inputs) {
   }
 
   // Go through each stream in the file.
-  for (let i = 0; i < file.ffProbeData.streams.length; i++) {
+  for (let i = 0; i < file.ffProbeData.streams.length; i += 1) {
     // Check if stream is a video.
     if (file.ffProbeData.streams[i].codec_type.toLowerCase() === 'video') {
       try {
         // Check if stream title is not empty, if it's not empty set to "".
-        if (typeof file.ffProbeData.streams[i].tags.title !== 'undefined') {
+        if (
+          !(
+            typeof file.ffProbeData.streams[i].tags.title === 'undefined'
+            || file.ffProbeData.streams[i].tags.title === '""'
+            || file.ffProbeData.streams[i].tags.title === ''
+          )
+        ) {
           response.infoLog += `☒Video stream title is not empty. Removing title from stream ${i} \n`;
           ffmpegCommandInsert += ` -metadata:s:v:${videoIdx} title="" `;
           convert = true;
@@ -114,7 +119,13 @@ function plugin(file, librarySettings, inputs) {
       && inputs.clean_audio.toLowerCase() === 'true'
     ) {
       try {
-        if (typeof file.ffProbeData.streams[i].tags.title !== 'undefined') {
+        if (
+          !(
+            typeof file.ffProbeData.streams[i].tags.title === 'undefined'
+            || file.ffProbeData.streams[i].tags.title === '""'
+            || file.ffProbeData.streams[i].tags.title === ''
+          )
+        ) {
           if (file.ffProbeData.streams[i].tags.title.split('.').length - 1 > 3) {
             try {
               response.infoLog += `☒More then 3 full stops in audio title. Removing title from stream ${i} \n`;
@@ -151,7 +162,13 @@ function plugin(file, librarySettings, inputs) {
       && inputs.clean_subtitles.toLowerCase() === 'true'
     ) {
       try {
-        if (typeof file.ffProbeData.streams[i].tags.title !== 'undefined') {
+        if (
+          !(
+            typeof file.ffProbeData.streams[i].tags.title === 'undefined'
+            || file.ffProbeData.streams[i].tags.title === '""'
+            || file.ffProbeData.streams[i].tags.title === ''
+          )
+        ) {
           if (file.ffProbeData.streams[i].tags.title.split('.').length - 1 > 3) {
             try {
               response.infoLog += `☒More then 3 full stops in subtitle title. Removing title from stream ${i} \n`;