gabehf/Koito
1
0
Fork 0
mirror of https://github.com/gabehf/Koito.git synced 2026-03-20 04:36:33 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add listen_type to coalescing key

Browse source
This commit is contained in:
Matt Usifer 2026-03-09 19:58:36 -04:00
parent 0ec7b458cc
commit e14423c3eb
No known key found for this signature in database
GPG key ID: EE4A64261A186B9E
1 changed files with 3 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

13
engine/handlers/lbz_submit_listen.go
View file

@ -220,7 +220,7 @@ func LbzSubmitListenHandler(store db.DB, mbzc mbz.MusicBrainzCaller) func(w http
SkipSaveListen: req.ListenType == ListenTypePlayingNow, SkipSaveListen: req.ListenType == ListenTypePlayingNow,
} }
_, err, shared := sfGroup.Do(buildCaolescingKey(payload), func() (interface{}, error) { _, err, shared := sfGroup.Do(buildCaolescingKey(payload, req.ListenType), func() (interface{}, error) {
return 0, catalog.SubmitListen(r.Context(), store, opts) return 0, catalog.SubmitListen(r.Context(), store, opts)
}) })
if shared { if shared {
@ -308,13 +308,6 @@ func doLbzRelay(requestBytes []byte, l *zerolog.Logger) {
} }
} }
func buildCaolescingKey(p LbzSubmitListenPayload) string { func buildCaolescingKey(p LbzSubmitListenPayload, listenType LbzListenType) string {
// the key not including the listen_type introduces the very rare possibility of a playing_now return fmt.Sprintf("%s:%s:%s:%s", listenType, p.TrackMeta.ArtistName, p.TrackMeta.TrackName, p.TrackMeta.ReleaseName)
// request taking precedence over a single, meaning that a listen will not be logged when it
// should, however that would require a playing_now request to fire a few seconds before a 'single'
// of the same track, which should never happen outside of misbehaving clients
//
// this could be fixed by restructuring the database inserts for idempotency, which would
// eliminate the need to coalesce responses, however i'm not gonna do that right now
return fmt.Sprintf("%s:%s:%s", p.TrackMeta.ArtistName, p.TrackMeta.TrackName, p.TrackMeta.ReleaseName)
} }