gabehf/Koito
1
0
Fork 0
mirror of https://github.com/gabehf/Koito.git synced 2026-03-07 13:38:15 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: weaken search similarity constraint

Browse source
This commit is contained in:
Gabe Farrell 2025-06-13 18:30:51 -04:00
parent e92733823d
commit d3fd53ca4c
3 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
db/queries/search.sql
View file

@ -10,7 +10,7 @@ FROM (
ROW_NUMBER() OVER (PARTITION BY a.id ORDER BY similarity(aa.alias, $1) DESC) AS rn ROW_NUMBER() OVER (PARTITION BY a.id ORDER BY similarity(aa.alias, $1) DESC) AS rn
FROM artist_aliases aa FROM artist_aliases aa
JOIN artists_with_name a ON aa.artist_id = a.id JOIN artists_with_name a ON aa.artist_id = a.id
WHERE similarity(aa.alias, $1) > 0.28 WHERE similarity(aa.alias, $1) > 0.22
) ranked ) ranked
WHERE rn = 1 WHERE rn = 1
ORDER BY score DESC ORDER BY score DESC
@ -60,7 +60,7 @@ FROM (
FROM track_aliases ta FROM track_aliases ta
JOIN tracks_with_title t ON ta.track_id = t.id JOIN tracks_with_title t ON ta.track_id = t.id
JOIN releases r ON t.release_id = r.id JOIN releases r ON t.release_id = r.id
WHERE similarity(ta.alias, $1) > 0.28 WHERE similarity(ta.alias, $1) > 0.22
) ranked ) ranked
WHERE rn = 1 WHERE rn = 1
ORDER BY score DESC, title ORDER BY score DESC, title
@ -123,7 +123,7 @@ FROM (
ROW_NUMBER() OVER (PARTITION BY r.id ORDER BY similarity(ra.alias, $1) DESC) AS rn ROW_NUMBER() OVER (PARTITION BY r.id ORDER BY similarity(ra.alias, $1) DESC) AS rn
FROM release_aliases ra FROM release_aliases ra
JOIN releases_with_title r ON ra.release_id = r.id JOIN releases_with_title r ON ra.release_id = r.id
WHERE similarity(ra.alias, $1) > 0.28 WHERE similarity(ra.alias, $1) > 0.22
) ranked ) ranked
WHERE rn = 1 WHERE rn = 1
ORDER BY score DESC, title ORDER BY score DESC, title

6
internal/db/psql/search_test.go
View file

@ -19,7 +19,7 @@ func setupTestDataForSearch(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
err = store.Exec(context.Background(), err = store.Exec(context.Background(),
`INSERT INTO artist_aliases (artist_id, alias, source, is_primary) `INSERT INTO artist_aliases (artist_id, alias, source, is_primary)
VALUES (1, 'Artist One With A Long Name', 'Testing', true), VALUES (1, 'Artist One With A Really Long Name', 'Testing', true),
(2, 'Artist Two', 'Testing', true)`) (2, 'Artist Two', 'Testing', true)`)
require.NoError(t, err) require.NoError(t, err)
@ -64,10 +64,10 @@ func TestSearchArtists(t *testing.T) {
setupTestDataForSearch(t) setupTestDataForSearch(t)
// Search for "Artist One With A Long Name" // Search for "Artist One With A Long Name"
results, err := store.SearchArtists(ctx, "Artist One With A Long Name") results, err := store.SearchArtists(ctx, "Artist One With A Really Long Name")
require.NoError(t, err) require.NoError(t, err)
require.Len(t, results, 1) require.Len(t, results, 1)
assert.Equal(t, "Artist One With A Long Name", results[0].Name) assert.Equal(t, "Artist One With A Really Long Name", results[0].Name)
// Search for substring "Artist" // Search for substring "Artist"
results, err = store.SearchArtists(ctx, "Arti") results, err = store.SearchArtists(ctx, "Arti")

6
internal/repository/search.sql.go
View file

@ -24,7 +24,7 @@ FROM (
ROW_NUMBER() OVER (PARTITION BY a.id ORDER BY similarity(aa.alias, $1) DESC) AS rn ROW_NUMBER() OVER (PARTITION BY a.id ORDER BY similarity(aa.alias, $1) DESC) AS rn
FROM artist_aliases aa FROM artist_aliases aa
JOIN artists_with_name a ON aa.artist_id = a.id JOIN artists_with_name a ON aa.artist_id = a.id
WHERE similarity(aa.alias, $1) > 0.28 WHERE similarity(aa.alias, $1) > 0.22
) ranked ) ranked
WHERE rn = 1 WHERE rn = 1
ORDER BY score DESC ORDER BY score DESC
@ -153,7 +153,7 @@ FROM (
ROW_NUMBER() OVER (PARTITION BY r.id ORDER BY similarity(ra.alias, $1) DESC) AS rn ROW_NUMBER() OVER (PARTITION BY r.id ORDER BY similarity(ra.alias, $1) DESC) AS rn
FROM release_aliases ra FROM release_aliases ra
JOIN releases_with_title r ON ra.release_id = r.id JOIN releases_with_title r ON ra.release_id = r.id
WHERE similarity(ra.alias, $1) > 0.28 WHERE similarity(ra.alias, $1) > 0.22
) ranked ) ranked
WHERE rn = 1 WHERE rn = 1
ORDER BY score DESC, title ORDER BY score DESC, title
@ -304,7 +304,7 @@ FROM (
FROM track_aliases ta FROM track_aliases ta
JOIN tracks_with_title t ON ta.track_id = t.id JOIN tracks_with_title t ON ta.track_id = t.id
JOIN releases r ON t.release_id = r.id JOIN releases r ON t.release_id = r.id
WHERE similarity(ta.alias, $1) > 0.28 WHERE similarity(ta.alias, $1) > 0.22
) ranked ) ranked
WHERE rn = 1 WHERE rn = 1
ORDER BY score DESC, title ORDER BY score DESC, title