Fix Maloja importer resilience: nil MBZ client, null album, error handling

Root cause of the panic at ~1,693 items: importers created
`&mbz.MusicBrainzClient{}` (nil requestQueue) instead of using the
engine's properly initialized client. When any code path called an MBZ
method, it panicked on the nil channel.

Changes:
- Pass engine's MBZ client to Maloja and Spotify importers
- Change MalojaTrack.Album to pointer type to handle null album JSON
- Continue on error instead of aborting the entire import
- Accept both Maloja export formats ("scrobbles" and "list" keys)
- Extract per-file import into importFile() with its own defer/recover
- Add progress logging every 500 items

Test fixtures:
- maloja_import_null_album_test.json (null album, valid album, empty artists)
- maloja_api_format_test.json (API "list" format)

New tests: TestImportMaloja_NullAlbum, TestImportMaloja_ApiFormat

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
safierinx-a 2026-03-24 23:58:45 +05:30
parent 0ec7b458cc
commit c2d393aa03
6 changed files with 224 additions and 55 deletions

View file

@ -0,0 +1,41 @@
{
"status": "ok",
"list": [
{
"time": 1746434410,
"track": {
"artists": [
"API Format Artist"
],
"title": "API Format Track",
"album": {
"artists": [
"API Format Artist"
],
"albumtitle": "API Format Album"
},
"length": null
},
"duration": null,
"origin": "client:default"
},
{
"time": 1746434682,
"track": {
"artists": [
"API Format Artist"
],
"title": "API Format Track 2",
"album": {
"artists": [
"API Format Artist"
],
"albumtitle": "API Format Album"
},
"length": null
},
"duration": null,
"origin": "client:default"
}
]
}