gabehf/Fladder
1
0
Fork 0
mirror of https://github.com/gabehf/Fladder.git synced 2026-03-07 21:48:14 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: Simplify subtitle rendering logic with early return

Browse source
This commit is contained in:
Kirill Boychenko 2025-07-28 01:20:30 +02:00
parent ee824f5f16
commit d60522b021
2 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/screens/video_player/video_player_controls.dart
View file

@ -289,7 +289,7 @@ class _DesktopControlsState extends ConsumerState<DesktopControls> {
}
Widget bottomButtons(BuildContext context) {
return Container(child: Consumer(builder: (context, ref, child) {
return Consumer(builder: (context, ref, child) {
final mediaPlayback = ref.watch(mediaPlaybackProvider);
final bitRateOptions = ref.watch(playBackModel.select((value) => value?.bitRateOptions));
return Container(
@ -430,7 +430,7 @@ class _DesktopControlsState extends ConsumerState<DesktopControls> {
),
),
);
}));
});
}
Widget progressBar(MediaPlaybackModel mediaPlayback) {

9
lib/wrappers/players/lib_mpv.dart
View file

@ -260,13 +260,8 @@ class _VideoSubtitlesState extends ConsumerState<_VideoSubtitles> {
// Process subtitle text
final text = subtitle.where((line) => line.trim().isNotEmpty).map((line) => line.trim()).join('\n');
// Return empty widget if libass is enabled (native subtitle rendering)
if (widget.controller.player.platform?.configuration.libass ?? false) {
return const SizedBox.shrink();
}
// Return empty widget if no subtitle text
if (text.isEmpty) {
// Early return for cases where subtitles shouldn't be rendered
if ((widget.controller.player.platform?.configuration.libass ?? false) || text.isEmpty) {
return const SizedBox.shrink();
}