gabehf/Fladder
1
0
Fork 0
mirror of https://github.com/gabehf/Fladder.git synced 2026-03-13 01:10:31 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: Improve subtitle positioning logic and remove outdated tests

Browse source
This commit is contained in:
Kirill Boychenko 2025-07-28 20:23:36 +02:00
parent 2884a5fadc
commit c446210e6a
4 changed files with 15 additions and 137 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/screens/video_player/video_player_controls.dart
View file

@ -112,6 +112,12 @@ class _DesktopControlsState extends ConsumerState<DesktopControls> {
timer.reset();
}
// Height measurement logic remains here for architectural reasons:
// 1. The video controls widget owns and renders the bottom menu UI elements
// 2. Only this widget has direct access to the menu's RenderBox for accurate measurement
// 3. Subtitle widgets are separate components that shouldn't know about control UI structure
// 4. Different players (LibMPV, MDK) can receive the same measurement without duplicating logic
// 5. Clean separation: controls handle UI measurement, players handle subtitle positioning
// Use PostFrameCallback to measure height after layout
void _measureMenuHeight() {
WidgetsBinding.instance.addPostFrameCallback((_) {