gabehf/Fladder
1
0
Fork 0
mirror of https://github.com/gabehf/Fladder.git synced 2026-03-07 21:48:14 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Incorrect progress updating for native player

Browse source
This commit is contained in:
PartyDonut 2025-10-26 18:07:26 +01:00
parent fa61ce2e40
commit a3ccb6009c
6 changed files with 57 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/src/video_player_helper.g.dart
View file

@ -911,7 +911,7 @@ class VideoPlayerApi {
}
}
Future<void> open(String url, bool play) async {
Future<bool> open(String url, bool play) async {
final String pigeonVar_channelName = 'dev.flutter.pigeon.nl_jknaapen_fladder.video.VideoPlayerApi.open$pigeonVar_messageChannelSuffix';
final BasicMessageChannel<Object?> pigeonVar_channel = BasicMessageChannel<Object?>(
pigeonVar_channelName,
@ -929,8 +929,13 @@ class VideoPlayerApi {
message: pigeonVar_replyList[1] as String?,
details: pigeonVar_replyList[2],
);
} else if (pigeonVar_replyList[0] == null) {
throw PlatformException(
code: 'null-error',
message: 'Host platform returned null value for non-null return value.',
);
} else {
return;
return (pigeonVar_replyList[0] as bool?)!;
}
}

2
lib/wrappers/media_control_wrapper.dart
View file

@ -264,7 +264,7 @@ class MediaControlsWrapper extends BaseAudioHandler implements VideoPlayerContro
final totalDuration = _player?.lastState.duration;
// //Small delay so we don't post right after playback/progress update
await Future.delayed(const Duration(seconds: 2));
await Future.delayed(const Duration(seconds: 1));
await playbackModel.playbackStopped(position ?? Duration.zero, totalDuration, ref);
ref.read(mediaPlaybackProvider.notifier).update((state) => state.copyWith(position: Duration.zero));

17
lib/wrappers/players/native_player.dart
View file

@ -15,11 +15,12 @@ import 'package:fladder/wrappers/players/player_states.dart';
class NativePlayer extends BasePlayer implements VideoPlayerListenerCallback {
final player = VideoPlayerApi();
final activity = NativeVideoActivity();
@override
Future<void> dispose() async {
nativeActivityStarted = false;
return NativeVideoActivity().disposeActivity();
return activity.disposeActivity();
}
@override
@ -36,7 +37,7 @@ class NativePlayer extends BasePlayer implements VideoPlayerListenerCallback {
@override
Future<StartResult> open(BuildContext newContext) async {
nativeActivityStarted = true;
return NativeVideoActivity().launchActivity();
return activity.launchActivity();
}
@override
@ -49,7 +50,11 @@ class NativePlayer extends BasePlayer implements VideoPlayerListenerCallback {
@override
Future<void> playOrPause() async {
return;
if (lastState.playing) {
return player.pause();
} else {
return player.play();
}
}
@override
@ -59,7 +64,7 @@ class NativePlayer extends BasePlayer implements VideoPlayerListenerCallback {
@override
Future<int> setAudioTrack(AudioStreamModel? model, PlaybackModel playbackModel) async {
return 0;
return model?.index ?? 0;
}
@override
@ -67,7 +72,7 @@ class NativePlayer extends BasePlayer implements VideoPlayerListenerCallback {
@override
Future<int> setSubtitleTrack(SubStreamModel? model, PlaybackModel playbackModel) async {
return 0;
return model?.index ?? 0;
}
@override
@ -177,6 +182,6 @@ class NativePlayer extends BasePlayer implements VideoPlayerListenerCallback {
),
url: model.media?.url ?? "",
);
player.sendPlayableModel(playableData);
await player.sendPlayableModel(playableData);
}
}