fix: Sync leaving left over temp files (#73)

Co-authored-by: PartyDonut <PartyDonut@users.noreply.github.com>

lib/screens/syncing/sync_item_details.dart

@@ -15,8 +15,8 @@ import 'package:fladder/screens/shared/default_alert_dialog.dart';
 import 'package:fladder/screens/shared/media/poster_widget.dart';
 import 'package:fladder/screens/syncing/sync_child_item.dart';
 import 'package:fladder/screens/syncing/sync_widgets.dart';
-import 'package:fladder/screens/syncing/widgets/sync_markedfordelete.dart';
 import 'package:fladder/screens/syncing/widgets/sync_progress_builder.dart';
+import 'package:fladder/screens/syncing/widgets/sync_status_overlay.dart';
 import 'package:fladder/util/adaptive_layout.dart';
 import 'package:fladder/util/list_padding.dart';
 import 'package:fladder/util/localization_helper.dart';
@@ -55,7 +55,7 @@ class _SyncItemDetailsState extends ConsumerState<SyncItemDetails> {
     final syncChildren = ref.read(syncProvider.notifier).getChildren(syncedItem);
     final downloadTask = ref.read(downloadTasksProvider(syncedItem.id));
 
-    return SyncMarkedForDelete(
+    return SyncStatusOverlay(
         syncedItem: syncedItem,
         child: ActionContent(
           title: Row(
@@ -135,7 +135,9 @@ class _SyncItemDetailsState extends ConsumerState<SyncItemDetails> {
                                     icon: const Icon(IconsaxBold.play),
                                   ),
                                   IconButton(
-                                    onPressed: () => ref.read(syncProvider.notifier).deleteFullSyncFiles(syncedItem),
+                                    onPressed: () => ref
+                                        .read(syncProvider.notifier)
+                                        .deleteFullSyncFiles(syncedItem, combinedStream?.task),
                                     icon: const Icon(IconsaxBold.stop),
                                   ),
                                 ],
@@ -177,7 +179,7 @@ class _SyncItemDetailsState extends ConsumerState<SyncItemDetails> {
                             context.localized.syncRemoveDataTitle,
                             context.localized.syncRemoveDataDesc,
                             (context) {
-                              ref.read(syncProvider.notifier).deleteFullSyncFiles(syncedItem);
+                              ref.read(syncProvider.notifier).deleteFullSyncFiles(syncedItem, downloadTask.task);
                               Navigator.of(context).pop();
                             },
                             context.localized.delete,
@@ -217,7 +219,7 @@ class _SyncItemDetailsState extends ConsumerState<SyncItemDetails> {
                     context.localized.syncDeleteItemTitle,
                     context.localized.syncDeleteItemDesc(baseItem?.detailedName(context) ?? ""),
                     (context) async {
-                      await ref.read(syncProvider.notifier).removeSync(syncedItem);
+                      await ref.read(syncProvider.notifier).removeSync(context, syncedItem);
                       Navigator.pop(context);
                       Navigator.pop(context);
                     },

lib/screens/syncing/sync_list_item.dart

@@ -1,18 +1,20 @@
+import 'package:flutter/material.dart';
+
 import 'package:ficonsax/ficonsax.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+
 import 'package:fladder/models/syncing/sync_item.dart';
 import 'package:fladder/providers/sync/sync_provider_helpers.dart';
 import 'package:fladder/providers/sync_provider.dart';
 import 'package:fladder/screens/shared/default_alert_dialog.dart';
 import 'package:fladder/screens/syncing/sync_item_details.dart';
 import 'package:fladder/screens/syncing/sync_widgets.dart';
-import 'package:fladder/screens/syncing/widgets/sync_markedfordelete.dart';
 import 'package:fladder/screens/syncing/widgets/sync_progress_builder.dart';
+import 'package:fladder/screens/syncing/widgets/sync_status_overlay.dart';
 import 'package:fladder/util/fladder_image.dart';
 import 'package:fladder/util/list_padding.dart';
 import 'package:fladder/util/localization_helper.dart';
 import 'package:fladder/util/size_formatting.dart';
-import 'package:flutter/material.dart';
-import 'package:flutter_riverpod/flutter_riverpod.dart';
 
 class SyncListItem extends ConsumerStatefulWidget {
   final SyncedItem syncedItem;
@@ -29,7 +31,7 @@ class SyncListItemState extends ConsumerState<SyncListItem> {
     final baseItem = ref.read(syncProvider.notifier).getItem(syncedItem);
     return Padding(
       padding: const EdgeInsets.symmetric(vertical: 8),
-      child: SyncMarkedForDelete(
+      child: SyncStatusOverlay(
         syncedItem: syncedItem,
         child: Card(
           elevation: 1,
@@ -53,7 +55,7 @@ class SyncListItemState extends ConsumerState<SyncListItem> {
                   context.localized.deleteItem(baseItem?.detailedName(context) ?? ""),
                   context.localized.syncDeletePopupPermanent,
                   (context) async {
-                    ref.read(syncProvider.notifier).removeSync(syncedItem);
+                    ref.read(syncProvider.notifier).removeSync(context, syncedItem);
                     Navigator.of(context).pop();
                     return true;
                   },

lib/screens/syncing/sync_widgets.dart

@@ -1,5 +1,9 @@
+import 'package:flutter/material.dart';
+
 import 'package:background_downloader/background_downloader.dart';
 import 'package:ficonsax/ficonsax.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+
 import 'package:fladder/models/items/episode_model.dart';
 import 'package:fladder/models/items/season_model.dart';
 import 'package:fladder/models/items/series_model.dart';
@@ -10,8 +14,6 @@ import 'package:fladder/providers/sync/sync_provider_helpers.dart';
 import 'package:fladder/providers/sync_provider.dart';
 import 'package:fladder/util/list_padding.dart';
 import 'package:fladder/util/localization_helper.dart';
-import 'package:flutter/material.dart';
-import 'package:flutter_riverpod/flutter_riverpod.dart';
 
 class SyncLabel extends ConsumerWidget {
   final String? label;
@@ -28,7 +30,7 @@ class SyncLabel extends ConsumerWidget {
       child: Padding(
         padding: const EdgeInsets.symmetric(horizontal: 6, vertical: 2),
         child: Text(
-          label ?? status.label,
+          label ?? status.label(context),
           style: Theme.of(context).textTheme.bodyMedium?.copyWith(
                 fontWeight: FontWeight.bold,
                 color: status.color,
@@ -55,7 +57,7 @@ class SyncProgressBar extends ConsumerWidget {
     return Column(
       crossAxisAlignment: CrossAxisAlignment.start,
       children: [
-        Text(downloadStatus.name),
+        Text(downloadStatus.name(context)),
         Row(
           crossAxisAlignment: CrossAxisAlignment.center,
           mainAxisSize: MainAxisSize.min,
@@ -82,7 +84,7 @@ class SyncProgressBar extends ConsumerWidget {
                 icon: const Icon(IconsaxBold.play),
               ),
               IconButton(
-                onPressed: () => ref.read(syncProvider.notifier).deleteFullSyncFiles(item),
+                onPressed: () => ref.read(syncProvider.notifier).deleteFullSyncFiles(item, downloadTask),
                 icon: const Icon(IconsaxBold.stop),
               )
             ],
@@ -129,7 +131,7 @@ class SyncSubtitle extends ConsumerWidget {
                   );
                 },
               ),
-            _ => Text(syncStatus.label),
+            _ => Text(syncStatus.label(context)),
           },
         ),
       ),

lib/screens/syncing/widgets/sync_status_overlay.dart

@@ -5,12 +5,12 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
 
 import 'package:fladder/models/syncing/sync_item.dart';
 import 'package:fladder/util/list_padding.dart';
+import 'package:fladder/util/localization_helper.dart';
 
-///This is a wrapper widget for marking a synced item as deleted (while it is being deleted)
-class SyncMarkedForDelete extends ConsumerWidget {
+class SyncStatusOverlay extends ConsumerWidget {
   final SyncedItem syncedItem;
   final Widget child;
-  const SyncMarkedForDelete({required this.syncedItem, required this.child, super.key});
+  const SyncStatusOverlay({required this.syncedItem, required this.child, super.key});
 
   @override
   Widget build(BuildContext context, WidgetRef ref) {
@@ -32,12 +32,35 @@ class SyncMarkedForDelete extends ConsumerWidget {
                     strokeCap: StrokeCap.round,
                     valueColor: AlwaysStoppedAnimation(Theme.of(context).colorScheme.error),
                   ),
-                  const Text("Deleting"),
+                  Text(context.localized.syncOverlayDeleting),
                   const Icon(IconsaxOutline.trash)
                 ].addPadding(const EdgeInsets.symmetric(horizontal: 16)),
               ),
             ),
-          )
+          ),
+        if (syncedItem.syncing)
+          Positioned.fill(
+            child: IgnorePointer(
+              child: Card(
+                elevation: 0,
+                semanticContainer: false,
+                color: Colors.black.withOpacity(0.6),
+                child: Row(
+                  mainAxisSize: MainAxisSize.max,
+                  mainAxisAlignment: MainAxisAlignment.center,
+                  crossAxisAlignment: CrossAxisAlignment.center,
+                  children: [
+                    CircularProgressIndicator.adaptive(
+                      strokeCap: StrokeCap.round,
+                      valueColor: AlwaysStoppedAnimation(Theme.of(context).colorScheme.error),
+                    ),
+                    Text(context.localized.syncOverlaySyncing),
+                    const Icon(IconsaxOutline.cloud_notif)
+                  ].addPadding(const EdgeInsets.symmetric(horizontal: 16)),
+                ),
+              ),
+            ),
+          ),
       ],
     );
   }

lib/screens/syncing/widgets/synced_episode_item.dart

@@ -1,4 +1,8 @@
+import 'package:flutter/material.dart';
+
 import 'package:ficonsax/ficonsax.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+
 import 'package:fladder/models/items/episode_model.dart';
 import 'package:fladder/models/syncing/sync_item.dart';
 import 'package:fladder/providers/sync/sync_provider_helpers.dart';
@@ -10,8 +14,6 @@ import 'package:fladder/util/list_padding.dart';
 import 'package:fladder/util/localization_helper.dart';
 import 'package:fladder/util/size_formatting.dart';
 import 'package:fladder/widgets/shared/icon_button_await.dart';
-import 'package:flutter/material.dart';
-import 'package:flutter_riverpod/flutter_riverpod.dart';
 
 class SyncedEpisodeItem extends ConsumerStatefulWidget {
   const SyncedEpisodeItem({
@@ -106,7 +108,7 @@ class _SyncedEpisodeItemState extends ConsumerState<SyncedEpisodeItem> {
                 context.localized.syncRemoveDataTitle,
                 context.localized.syncRemoveDataDesc,
                 (context) async {
-                  await ref.read(syncProvider.notifier).deleteFullSyncFiles(syncedItem);
+                  await ref.read(syncProvider.notifier).deleteFullSyncFiles(syncedItem, downloadTask.task);
                   Navigator.pop(context);
                 },
                 context.localized.delete,