From 7877cae8ea8bde9e27657bd9a219c79a24d859f2 Mon Sep 17 00:00:00 2001 From: PartyDonut <42371342+PartyDonut@users.noreply.github.com> Date: Thu, 28 Nov 2024 21:47:07 +0100 Subject: [PATCH] fix: Player orientation title (#166) Co-authored-by: PartyDonut --- lib/screens/settings/client_settings_page.dart | 6 +++--- lib/screens/settings/player_settings_page.dart | 2 +- .../video_player/components/video_player_options_sheet.dart | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/screens/settings/client_settings_page.dart b/lib/screens/settings/client_settings_page.dart index 3ac2323..6a491d1 100644 --- a/lib/screens/settings/client_settings_page.dart +++ b/lib/screens/settings/client_settings_page.dart @@ -392,7 +392,7 @@ class _ClientSettingsPageState extends ConsumerState { context, label: "${context.localized.theme} ${context.localized.mode}", items: ThemeMode.values, - itemBuilder: (type) => RadioListTile.adaptive( + itemBuilder: (type) => RadioListTile( value: type, title: Text(type?.label(context) ?? context.localized.other), contentPadding: EdgeInsets.zero, @@ -414,7 +414,7 @@ class _ClientSettingsPageState extends ConsumerState { builder: (context, ref, child) => ListTile( title: Row( children: [ - Checkbox.adaptive( + Checkbox( value: type == ref.watch(clientSettingsProvider.select((value) => value.themeColor)), onChanged: (value) => ref.read(clientSettingsProvider.notifier).setThemeColor(type), ), @@ -463,7 +463,7 @@ class _ClientSettingsPageState extends ConsumerState { builder: (context, ref, child) => ListTile( title: Row( children: [ - Checkbox.adaptive( + Checkbox( value: type == ref.watch(clientSettingsProvider.select((value) => value.schemeVariant)), onChanged: (value) => ref.read(clientSettingsProvider.notifier).setSchemeVariant(type), ), diff --git a/lib/screens/settings/player_settings_page.dart b/lib/screens/settings/player_settings_page.dart index aa27a85..8b79cc9 100644 --- a/lib/screens/settings/player_settings_page.dart +++ b/lib/screens/settings/player_settings_page.dart @@ -67,7 +67,7 @@ class _PlayerSettingsPageState extends ConsumerState { context, label: context.localized.videoScalingFillScreenTitle, items: BoxFit.values, - itemBuilder: (type) => RadioListTile.adaptive( + itemBuilder: (type) => RadioListTile( title: Text(type?.label(context) ?? ""), value: type, shape: RoundedRectangleBorder(borderRadius: BorderRadius.circular(16)), diff --git a/lib/screens/video_player/components/video_player_options_sheet.dart b/lib/screens/video_player/components/video_player_options_sheet.dart index dd823ba..273890e 100644 --- a/lib/screens/video_player/components/video_player_options_sheet.dart +++ b/lib/screens/video_player/components/video_player_options_sheet.dart @@ -173,7 +173,7 @@ class _VideoOptionsMobileState extends ConsumerState { child: Text(context.localized.videoScalingFill), ), const Spacer(), - Switch.adaptive( + Switch( value: videoSettings.fillScreen, onChanged: (value) => ref.read(videoPlayerSettingsProvider.notifier).setFillScreen(value), ) @@ -524,7 +524,7 @@ Future showOrientationOptions(BuildContext context, WidgetRef ref) async { return StatefulBuilder(builder: (context, state) { return SimpleDialog( contentPadding: const EdgeInsets.only(top: 8, bottom: 24), - title: Row(children: [Text(context.localized.playbackRate)]), + title: Row(children: [Text(context.localized.playerSettingsOrientationTitle)]), children: [ Padding( padding: const EdgeInsets.symmetric(horizontal: 12).copyWith(top: 6), @@ -535,7 +535,7 @@ Future showOrientationOptions(BuildContext context, WidgetRef ref) async { children: [ const Divider(), ...DeviceOrientation.values.map( - (orientation) => CheckboxListTile.adaptive( + (orientation) => CheckboxListTile( title: Text(orientation.label(context)), value: orientations.contains(orientation), onChanged: (value) {