gabehf/Fladder
1
0
Fork 0
mirror of https://github.com/gabehf/Fladder.git synced 2026-03-10 07:50:28 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

[Bugfix] Stream options padding

Browse source 
[Bugfix] Stream - Off not showing as selected
This commit is contained in:
PartyDonut 2024-10-10 23:53:16 +02:00
parent 9c69e05b75
commit 67793b0f13
1 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
lib/screens/details_screens/components/media_stream_information.dart
View file

@ -1,10 +1,10 @@
import 'package:fladder/util/localization_helper.dart';
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart'; import 'package:flutter_riverpod/flutter_riverpod.dart';
import 'package:fladder/models/items/media_streams_model.dart'; import 'package:fladder/models/items/media_streams_model.dart';
import 'package:fladder/screens/details_screens/components/label_title_item.dart'; import 'package:fladder/screens/details_screens/components/label_title_item.dart';
import 'package:fladder/util/localization_helper.dart';
class MediaStreamInformation extends ConsumerWidget { class MediaStreamInformation extends ConsumerWidget {
final MediaStreamsModel mediaStream; final MediaStreamsModel mediaStream;
@ -27,8 +27,8 @@ class MediaStreamInformation extends ConsumerWidget {
.map( .map(
(e) => PopupMenuItem( (e) => PopupMenuItem(
value: e, value: e,
padding: EdgeInsets.zero,
child: Text(e.prettyName), child: Text(e.prettyName),
onTap: () {},
), ),
) )
.toList(), .toList(),
@ -42,7 +42,8 @@ class MediaStreamInformation extends ConsumerWidget {
(e) => PopupMenuItem( (e) => PopupMenuItem(
value: e, value: e,
padding: EdgeInsets.zero, padding: EdgeInsets.zero,
child: textWidget(context, selected: mediaStream.currentAudioStream == e, label: e.displayTitle), child: textWidget(context,
selected: mediaStream.currentAudioStream?.index == e.index, label: e.displayTitle),
onTap: () => onAudioIndexChanged?.call(e.index), onTap: () => onAudioIndexChanged?.call(e.index),
), ),
) )
@ -57,7 +58,8 @@ class MediaStreamInformation extends ConsumerWidget {
(e) => PopupMenuItem( (e) => PopupMenuItem(
value: e, value: e,
padding: EdgeInsets.zero, padding: EdgeInsets.zero,
child: textWidget(context, selected: mediaStream.currentSubStream == e, label: e.displayTitle), child: textWidget(context,
selected: mediaStream.currentSubStream?.index == e.index, label: e.displayTitle),
onTap: () => onSubIndexChanged?.call(e.index), onTap: () => onSubIndexChanged?.call(e.index),
), ),
) )
@ -100,7 +102,7 @@ class _StreamOptionSelect<T> extends StatelessWidget {
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
final textStyle = Theme.of(context).textTheme.titleMedium; final textStyle = Theme.of(context).textTheme.titleMedium;
const padding = EdgeInsets.all(6.0); const padding = EdgeInsets.all(6);
final itemList = itemBuilder(context); final itemList = itemBuilder(context);
return LabelTitleItem( return LabelTitleItem(
title: label, title: label,
@ -110,6 +112,7 @@ class _StreamOptionSelect<T> extends StatelessWidget {
shape: RoundedRectangleBorder(borderRadius: BorderRadius.circular(16)), shape: RoundedRectangleBorder(borderRadius: BorderRadius.circular(16)),
enabled: itemList.length > 1, enabled: itemList.length > 1,
itemBuilder: itemBuilder, itemBuilder: itemBuilder,
menuPadding: const EdgeInsets.symmetric(vertical: 16),
padding: padding, padding: padding,
child: Padding( child: Padding(
padding: padding, padding: padding,