gabehf/Fladder
1
0
Fork 0
mirror of https://github.com/gabehf/Fladder.git synced 2026-03-07 13:38:13 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Force transcoding of subtitles with nativePlayer + external (#592)

Browse source 
Co-authored-by: PartyDonut <PartyDonut@users.noreply.github.com>
This commit is contained in:
PartyDonut 2025-11-08 16:38:14 +01:00 • committed by GitHub
parent 2594a8463f
commit 0e4514af84
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 43 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/models/playback/playback_model.dart
View file

@ -22,6 +22,7 @@ import 'package:fladder/models/playback/direct_playback_model.dart';
import 'package:fladder/models/playback/offline_playback_model.dart';
import 'package:fladder/models/playback/playback_options_dialogue.dart';
import 'package:fladder/models/playback/transcode_playback_model.dart';
import 'package:fladder/models/settings/video_player_settings.dart';
import 'package:fladder/models/syncing/sync_item.dart';
import 'package:fladder/models/video_stream_model.dart';
import 'package:fladder/profiles/default_profile.dart';
@ -277,12 +278,18 @@ class PlaybackModelHelper {
oldModel?.mediaStreams?.currentAudioStream,
newStreamModel?.audioStreams,
newStreamModel?.defaultAudioStreamIndex);
final subStreamIndex = selectSubStream(
ref.read(userProvider.select((value) => value?.userConfiguration?.rememberSubtitleSelections ?? true)),
oldModel?.mediaStreams?.currentSubStream,
newStreamModel?.subStreams,
newStreamModel?.defaultSubStreamIndex);
//Native player does not allow for loading external subtitles with transcoding
final isNativePlayer =
ref.read(videoPlayerSettingsProvider.select((value) => value.wantedPlayer == PlayerOptions.nativePlayer));
final isExternalSub = newStreamModel?.currentSubStream?.isExternal == true;
final Response<PlaybackInfoResponse> response = await api.itemsItemIdPlaybackInfoPost(
itemId: item.id,
body: PlaybackInfoDto(
@ -295,6 +302,7 @@ class PlaybackModelHelper {
userId: userId,
enableDirectPlay: type != PlaybackType.transcode,
enableDirectStream: type != PlaybackType.transcode,
alwaysBurnInSubtitleWhenTranscoding: isNativePlayer && isExternalSub,
maxStreamingBitrate: qualityOptions.enabledFirst.keys.firstOrNull?.bitRate,
mediaSourceId: newStreamModel?.currentVersionStream?.id,
),