Report that admin data is not included

pull/1/head
Liam Morley 4 years ago
parent 78b29cc86d
commit eff22d2ac8

@ -1,6 +1,6 @@
class AdminDataPresenter < DataItemPresenter class AdminDataPresenter < DataItemPresenter
def initialize(measure_id:, admin_data_items:) def initialize(measure_id:, admin_data_items:)
super(measure_id: measure_id, has_sufficient_data: true) super(measure_id: measure_id, has_sufficient_data: false)
@admin_data_items = admin_data_items @admin_data_items = admin_data_items
end end
@ -15,4 +15,8 @@ class AdminDataPresenter < DataItemPresenter
def item_descriptions def item_descriptions
@admin_data_items.map(&:description) @admin_data_items.map(&:description)
end end
def reason_for_insufficiency
"limited availability"
end
end end

@ -15,4 +15,8 @@ class StudentSurveyPresenter < DataItemPresenter
def item_descriptions def item_descriptions
@survey_items.map(&:prompt) @survey_items.map(&:prompt)
end end
def reason_for_insufficiency
"low response rate"
end
end end

@ -15,4 +15,8 @@ class TeacherSurveyPresenter < DataItemPresenter
def item_descriptions def item_descriptions
@survey_items.map(&:prompt) @survey_items.map(&:prompt)
end end
def reason_for_insufficiency
"low response rate"
end
end end

@ -23,7 +23,7 @@
<div class="accordion-body measure-accordion-body font-cabin font-size-14 weight-400"> <div class="accordion-body measure-accordion-body font-cabin font-size-14 weight-400">
<% unless data_item_section.sufficient_data? %> <% unless data_item_section.sufficient_data? %>
<div class="alert alert-secondary" role="alert"> <div class="alert alert-secondary" role="alert">
Data not included due to low response rate Data not included due to <%= data_item_section.reason_for_insufficiency %>
</div> </div>
<% end %> <% end %>
<ul> <ul>

@ -54,7 +54,6 @@ describe MeasurePresenter do
expect(second_data_item_presenter.title).to eq 'School admin data' expect(second_data_item_presenter.title).to eq 'School admin data'
expect(second_data_item_presenter.data_item_accordion_id).to eq 'data-item-accordion-measure-id' expect(second_data_item_presenter.data_item_accordion_id).to eq 'data-item-accordion-measure-id'
expect(second_data_item_presenter.item_descriptions).to eq ["An admin data item description", "Another admin data item description"] expect(second_data_item_presenter.item_descriptions).to eq ["An admin data item description", "Another admin data item description"]
expect(second_data_item_presenter.sufficient_data?).to be true
end end
end end
@ -75,5 +74,22 @@ describe MeasurePresenter do
end end
end end
context 'when the measure has insufficient admin data and insufficient teacher/student data' do
before :each do
create(:admin_data_item, measure: measure)
create(:teacher_survey_item, measure: measure)
create(:student_survey_item, measure: measure)
end
it 'tracks the reason for their insufficiency' do
teacher_data_item_presenter = measure_presenter.data_item_presenters.find { |presenter| presenter.title == 'Teacher survey' }
student_data_item_presenter = measure_presenter.data_item_presenters.find { |presenter| presenter.title == 'Student survey' }
admin_data_item_presenter = measure_presenter.data_item_presenters.find { |presenter| presenter.title == 'School admin data' }
expect(teacher_data_item_presenter.reason_for_insufficiency).to eq 'low response rate'
expect(student_data_item_presenter.reason_for_insufficiency).to eq 'low response rate'
expect(admin_data_item_presenter.reason_for_insufficiency).to eq 'limited availability'
end
end
end end

Loading…
Cancel
Save