From edeb3f4e59b6ce8f77b109c3837bcc038a87be54 Mon Sep 17 00:00:00 2001 From: rebuilt Date: Mon, 8 Nov 2021 21:28:30 +0100 Subject: [PATCH] Prevent memory errors by avoiding creating active record objects when not necessary. --- app/models/survey_item_response.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/models/survey_item_response.rb b/app/models/survey_item_response.rb index 89a40e18..640d8fab 100644 --- a/app/models/survey_item_response.rb +++ b/app/models/survey_item_response.rb @@ -17,7 +17,8 @@ class SurveyItemResponse < ActiveRecord::Base def self.score_for_measure(measure:, school:, academic_year:) survey_item_responses = for_measure_meeting_threshold(measure: measure, school: school, academic_year: academic_year) - if survey_item_responses.present? + + unless survey_item_responses.nil? survey_item_responses .where(academic_year: academic_year, school: school) .average(:likert_score)