From ed755c6732febc2aaab91a3639b93064e705e167 Mon Sep 17 00:00:00 2001 From: Nelson Jovel Date: Wed, 6 Dec 2023 14:58:56 -0800 Subject: [PATCH] chore: refactor code so we use a hash instead of a switch statement for long-term performance --- app/models/income.rb | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/app/models/income.rb b/app/models/income.rb index c3cf706b..2402876c 100644 --- a/app/models/income.rb +++ b/app/models/income.rb @@ -17,14 +17,13 @@ class Income < ApplicationRecord end end + LABELS = { + "Economically Disadvantaged - Y" => "Economically Disadvantaged", + "Economically Disadvantaged - N" => "Not Economically Disadvantaged", + "Unknown" => "Unknown" + } + def label - case designation - when "Economically Disadvantaged - Y" - "Economically Disadvantaged" - when "Economically Disadvantaged - N" - "Not Economically Disadvantaged" - when "Unknown" - "Unknown" - end + LABELS[designation] end end